Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s: fix API call to _wait_for_response #53937

Merged
merged 1 commit into from Apr 20, 2019

Conversation

Projects
None yet
3 participants
@Akasurde
Copy link
Member

commented Mar 18, 2019

SUMMARY

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/module_utils/k8s/scale.py

k8s: fix API call to _wait_for_response
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot

This comment has been minimized.

@willthames

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2019

This might be a good time to add a test to the k8s test suite for k8s_scale - any chance we can get that in before the freeze?

I'm not really sure how this hasn't been spotted previously?

@ansibot ansibot removed the needs_triage label Mar 18, 2019

@ansibot ansibot added the stale_ci label Mar 26, 2019

@Akasurde

This comment has been minimized.

Copy link
Member Author

commented Apr 5, 2019

@willthames I am afraid due to my current workload, I won't be able to add test case for now. Thanks.

@Akasurde

This comment has been minimized.

Copy link
Member Author

commented Apr 20, 2019

rebuild_merge

@ansibot ansibot merged commit 94f295e into ansible:devel Apr 20, 2019

1 check passed

Shippable Run 120032 status is SUCCESS.
Details

@Akasurde Akasurde deleted the Akasurde:k8s_scale_fix branch Apr 20, 2019

ruimoreira added a commit to ruimoreira/ansible that referenced this pull request Apr 22, 2019

k8s: fix API call to _wait_for_response (ansible#53937)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.