Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add os_server_tag module #53951

Open
wants to merge 5 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@n-ik
Copy link

n-ik commented Mar 18, 2019

SUMMARY

Add new module os_server_tag to set or remove tag on the openstack server instance

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

module.cloud.openstack.os_server_tag

ADDITIONAL INFORMATION

A new module to set and remove tags on openstack server instance.

Dominik Stucki
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 18, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_server_tag.py:120:0: trailing-newlines Trailing newlines

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_server_tag.py:68:0: ImportError: No module named openstack

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_server_tag.py:68:0: ImportError: No module named openstack

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_server_tag.py:68:0: ImportError: No module named 'openstack'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_server_tag.py:68:0: ModuleNotFoundError: No module named 'openstack'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_server_tag.py:68:0: ModuleNotFoundError: No module named 'openstack'

The test ansible-test sanity --test import --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_server_tag.py:68:0: ModuleNotFoundError: No module named 'openstack'

The test ansible-test sanity --test pep8 [explain] failed with 6 errors:

lib/ansible/modules/cloud/openstack/os_server_tag.py:66:9: E126 continuation line over-indented for hanging indent
lib/ansible/modules/cloud/openstack/os_server_tag.py:70:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/openstack/os_server_tag.py:73:5: E303 too many blank lines (2)
lib/ansible/modules/cloud/openstack/os_server_tag.py:104:30: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/openstack/os_server_tag.py:105:30: E124 closing bracket does not match visual indentation
lib/ansible/modules/cloud/openstack/os_server_tag.py:120:1: W391 blank line at end of file

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/cloud/openstack/os_server_tag.py:0:0: E321 Exception attempting to import module for argument_spec introspection, 'No module named 'openstack''
lib/ansible/modules/cloud/openstack/os_server_tag.py:119:0: E109 Next to last line should be: if __name__ == "__main__":

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 18, 2019

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_server_tag.py:72:0: ImportError: No module named openstack

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_server_tag.py:72:0: ImportError: No module named openstack

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_server_tag.py:72:0: ImportError: No module named 'openstack'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_server_tag.py:72:0: ModuleNotFoundError: No module named 'openstack'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_server_tag.py:72:0: ModuleNotFoundError: No module named 'openstack'

The test ansible-test sanity --test import --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_server_tag.py:72:0: ModuleNotFoundError: No module named 'openstack'

The test ansible-test sanity --test pep8 [explain] failed with 7 errors:

lib/ansible/modules/cloud/openstack/os_server_tag.py:66:9: E126 continuation line over-indented for hanging indent
lib/ansible/modules/cloud/openstack/os_server_tag.py:70:3: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/openstack/os_server_tag.py:72:3: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/openstack/os_server_tag.py:74:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/openstack/os_server_tag.py:77:5: E303 too many blank lines (2)
lib/ansible/modules/cloud/openstack/os_server_tag.py:108:30: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/openstack/os_server_tag.py:109:30: E124 closing bracket does not match visual indentation

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_server_tag.py:0:0: E321 Exception attempting to import module for argument_spec introspection, 'No module named 'openstack''

click here for bot help

@openstack-zuul

This comment has been minimized.

Copy link

openstack-zuul bot commented Mar 18, 2019

Build succeeded (third-party-check pipeline).

Dominik Stucki
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 19, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_server_tag.py:122:0: trailing-newlines Trailing newlines

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_server_tag.py:72:0: ImportError: No module named openstack

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_server_tag.py:72:0: ImportError: No module named openstack

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_server_tag.py:72:0: ImportError: No module named 'openstack'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_server_tag.py:72:0: ModuleNotFoundError: No module named 'openstack'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_server_tag.py:72:0: ModuleNotFoundError: No module named 'openstack'

The test ansible-test sanity --test import --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_server_tag.py:72:0: ModuleNotFoundError: No module named 'openstack'

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_server_tag.py:122:1: W391 blank line at end of file

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/cloud/openstack/os_server_tag.py:0:0: E321 Exception attempting to import module for argument_spec introspection, 'No module named 'openstack''
lib/ansible/modules/cloud/openstack/os_server_tag.py:121:0: E109 Next to last line should be: if __name__ == "__main__":

click here for bot help

@openstack-zuul

This comment has been minimized.

Copy link

openstack-zuul bot commented Mar 19, 2019

Build succeeded (third-party-check pipeline).

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 19, 2019

@SamYaple @agireud @albertomurillo @bennojoy @cloudnull @dagnello @dguerri @evrardjp @flwang @haneefs @ioggstream @juliakreger @Kong @kuboj @lingxiankong @matbu @mgale @mnaser @odyssey4me @omgjlk @ruizink @steveb

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@openstack-zuul

This comment has been minimized.

Copy link

openstack-zuul bot commented Mar 19, 2019

Build succeeded (third-party-check pipeline).

Dominik Stucki
@openstack-zuul

This comment has been minimized.

Copy link

openstack-zuul bot commented Mar 25, 2019

Build succeeded (third-party-check pipeline).

@gtema

This comment has been minimized.

Copy link
Contributor

gtema commented Mar 29, 2019

Generally you do the same what I did in #48086 and what I did before I landed tagging support in SDK. I have few problems with it:

  • min_version of SDK is not mentioned
  • when SDK is younger (let's be fair - 90% of cases) there would be no possibility to modify tags
@n-ik

This comment has been minimized.

Copy link
Author

n-ik commented Apr 1, 2019

@gtema
Thank you for your feedback.

  • min_version of SDK is not mentioned

Good point, I will add this. Do you know since when tags are supported?

  • when SDK is younger (let's be fair - 90% of cases) there would be no possibility to modify tags

You're right, but I think it makes more sense to support the modern way into ansible.
The other thing is, your way does not support multiple tags.

Do you have any other ideas? I am open for a solution that works for everyone.

@gtema

This comment has been minimized.

Copy link
Contributor

gtema commented Apr 3, 2019

  • min_version of SDK is not mentioned

Good point, I will add this. Do you know since when tags are supported?

0.21.0

  • when SDK is younger (let's be fair - 90% of cases) there would be no possibility to modify tags

You're right, but I think it makes more sense to support the modern way into ansible.

You can't even imagine the poorness of the world. In nearly each case I am working with SDK is still 0.12.0 (distro lag, AWX, etc). I am really struggling with that.

The other thing is, your way does not support multiple tags.

Now it does and also more - it supports managing tags on diverse resources (which support tagging) and also implements using low-level interface when SDK is too old.

@ansibot ansibot added the stale_ci label Apr 3, 2019

@ansibot ansibot removed the needs_triage label Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.