Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows - add docs around TLS protocols #54016

Merged
merged 2 commits into from Mar 21, 2019

Conversation

Projects
None yet
4 participants
@jborean93
Copy link
Contributor

commented Mar 19, 2019

SUMMARY

Consolidates the TLS information we have for WinRM in our docs. Tries to consolidate common errors and better ways to configure the Windows host to support TLS v1.2

Fixes #52316

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

Windows docs

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

The test ansible-test sanity --test docs-build [explain] failed with 1 error:

docs/docsite/rst/user_guide/windows_winrm.rst:505:0: undefined-label: undefined label: _winrm_tls12 (if the link has no caption the label must precede a section header)

click here for bot help

@Yvan-Masson

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

@jborean93 I read your patch, it looks great to me: there is everything that I think need explanations and the document is still very clear. A few warning however:

  • I am not an English native
  • I did not check if .rst syntax is correct
  • I did not check Windows commands nor Ansible tasks you added
@jborean93

This comment has been minimized.

Copy link
Contributor Author

commented Mar 19, 2019

Thanks @Yvan-Masson for the review, looks like I made some errors in the RST but that should be fixed now. Will wait for the docs team to review before merging.

@acozine

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

Looks good, thanks @jborean93 - and thanks @Yvan-Masson for looking. It helps to get reviews from folks who aren't native English speakers - we want our docs to be accessible to people who use English professionally.

@acozine acozine merged commit 6bd32b7 into ansible:devel Mar 21, 2019

1 check passed

Shippable Run 114796 status is SUCCESS.
Details

@jborean93 jborean93 deleted the jborean93:win-tls-docs branch Mar 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.