Make test-module use default value for interpreter #54053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.8
nitzmahone
requested changes
Mar 22, 2019
ansibot
added
needs_revision
|
Can you please add a simple integration test to verify this functionality and ensure we do not break this again. |
|
@sivel I've added a simple check to test/integration/targets/test_infra/runme.sh which will be caught by "set -e" if unclean exit, hope that's the right place to check test-module integrity? Cheers |
ansibot
added
the
support:community
sivel
approved these changes
Apr 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Since #50163 changes to Python interpreter discovery Ansible attempts to use the interpreter from discovered facts, however fact discovery is not performed in test-module, facts dict is empty, thus invocation always fails with ansible.executor.interpreter_discovery.InterpreterDiscoveryRequiredError raised in https://github.com/ansible/ansible/blob/devel/lib/ansible/executor/module_common.py#L496.
That is, unless -I or -interpreter is passed to test-module for every run, making this a required param. Rather than this being required we might consider defaulting to /usr/bin/python as was before, for module test purposes.
Test system: macOS 10.14.3, Python 2.7.15.
ISSUE TYPE