Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgng: Improve support for old pkgng in query_update #54078

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
2 participants
@koichirok
Copy link
Contributor

commented Mar 20, 2019

SUMMARY

pkgng module's state=latest does not work properly with pkgng older than 1.10.0.
This PR fixes above problem.

Note that this PR contains code for pkgng from 1.0 to 1.3 but I've tested only with pkgng 1.5.3 and pkgng 1.10.5.
Strings for pkgng <= 1.3 (e.g. "The following packages will be upgraded:") are obtained from source code of pkgng.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

pkgng module

ADDITIONAL INFORMATION

Tested ansible version:

ansible 2.7.7
  config file = ***/ansible.cfg
  configured module search path = ['***/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = ***/.anyenv/envs/pyenv/versions/3.6.4/envs/py36-ansible/lib/python3.6/site-packages/ansible
  executable location = ***/.anyenv/envs/pyenv/versions/py36-ansible/bin/ansible
  python version = 3.6.4 (default, May 22 2018, 18:35:08) [GCC 5.4.0 20160609]
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

lib/ansible/modules/packaging/os/pkgng.py:152:28: E261 at least two spaces before inline comment
lib/ansible/modules/packaging/os/pkgng.py:155:28: E261 at least two spaces before inline comment
lib/ansible/modules/packaging/os/pkgng.py:158:28: E261 at least two spaces before inline comment

click here for bot help

@koichirok koichirok force-pushed the koichirok:improve-old-pkgng-support-in-query_update branch to 1d9151c Mar 20, 2019

@ansibot ansibot added the stale_ci label Mar 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.