Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cloud Init variables for Proxmox_KVM module #54108

Open
wants to merge 6 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@nuttybrewer
Copy link

nuttybrewer commented Mar 20, 2019

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

nuttybrewer added some commits Mar 20, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 20, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 20, 2019

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/modules/cloud/misc/proxmox_kvm.py:642:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/cloud/misc/proxmox_kvm.py:773:0: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/misc/proxmox_kvm.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/misc/proxmox_kvm.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/misc/proxmox_kvm.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/misc/proxmox_kvm.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/misc/proxmox_kvm.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/cloud/misc/proxmox_kvm.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
PYTHONPATH=../../lib ../bin/dump_config.py --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ -d ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../bin/generate_man.py --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../bin/dump_keywords.py --template-dir=../templates --output-dir=rst/reference_appendices/ -d ./keyword_desc.yml
PYTHONPATH=../../lib ../bin/plugin_formatter.py -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Evaluating module files...
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../bin/plugin_formatter.py", line 783, in <module>
    main()
  File "../bin/plugin_formatter.py", line 738, in main
    plugin_info, categories = get_plugin_info(options.module_dir, limit_to=options.limit_to, verbose=(options.verbosity > 0))
  File "../bin/plugin_formatter.py", line 294, in get_plugin_info
    doc, examples, returndocs, metadata = plugin_docs.get_docstring(module_path, fragment_loader, verbose=verbose)
  File "/root/ansible/lib/ansible/utils/plugin_docs.py", line 105, in get_docstring
    data = read_docstring(filename, verbose=verbose, ignore_errors=ignore_errors)
  File "/root/ansible/lib/ansible/parsing/plugin_docs.py", line 59, in read_docstring
    data[varkey] = AnsibleLoader(child.value.s, file_name=filename).get_single_data()
  File "/usr/local/lib/python3.6/dist-packages/yaml/constructor.py", line 35, in get_single_data
    node = self.get_single_node()
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 36, in get_single_node
    document = self.compose_document()
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 55, in compose_document
    node = self.compose_node(None, None)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 127, in compose_mapping_node
    while not self.check_event(MappingEndEvent):
  File "/usr/local/lib/python3.6/dist-packages/yaml/parser.py", line 98, in check_event
    self.current_event = self.state()
  File "/usr/local/lib/python3.6/dist-packages/yaml/parser.py", line 428, in parse_block_mapping_key
    if self.check_token(KeyToken):
  File "/usr/local/lib/python3.6/dist-packages/yaml/scanner.py", line 116, in check_token
    self.fetch_more_tokens()
  File "/usr/local/lib/python3.6/dist-packages/yaml/scanner.py", line 220, in fetch_more_tokens
    return self.fetch_value()
  File "/usr/local/lib/python3.6/dist-packages/yaml/scanner.py", line 576, in fetch_value
    self.get_mark())
yaml.scanner.ScannerError: mapping values are not allowed here
  in "<unicode string>", line 267, column 28:
        description: Cloud Init: search domain to set for the D ... 
                               ^
make: *** [modules] Error 1

The test ansible-test sanity --test pep8 [explain] failed with 12 errors:

lib/ansible/modules/cloud/misc/proxmox_kvm.py:163:110: W291 trailing whitespace
lib/ansible/modules/cloud/misc/proxmox_kvm.py:472:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/misc/proxmox_kvm.py:490:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/misc/proxmox_kvm.py:507:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/misc/proxmox_kvm.py:639:3: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/misc/proxmox_kvm.py:641:3: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/misc/proxmox_kvm.py:642:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/misc/proxmox_kvm.py:733:15: E124 closing bracket does not match visual indentation
lib/ansible/modules/cloud/misc/proxmox_kvm.py:757:13: E117 over-indented (comment)
lib/ansible/modules/cloud/misc/proxmox_kvm.py:758:13: E117 over-indented (comment)
lib/ansible/modules/cloud/misc/proxmox_kvm.py:763:54: E228 missing whitespace around modulo operator
lib/ansible/modules/cloud/misc/proxmox_kvm.py:773:1: W293 blank line contains whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 10 errors:

lib/ansible/modules/cloud/misc/proxmox_kvm.py:0:0: E326 Argument 'bios' in argument_spec defines choices as (['seabios', 'ovmf']) but documentation defines choices as ([])
lib/ansible/modules/cloud/misc/proxmox_kvm.py:0:0: E326 Argument 'format' in argument_spec defines choices as (['cloop', 'cow', 'qcow', 'qcow2', 'qed', 'raw', 'vmdk']) but documentation defines choices as ([])
lib/ansible/modules/cloud/misc/proxmox_kvm.py:0:0: E326 Argument 'hugepages' in argument_spec defines choices as (['any', '2', '1024']) but documentation defines choices as ([])
lib/ansible/modules/cloud/misc/proxmox_kvm.py:0:0: E326 Argument 'lock' in argument_spec defines choices as (['migrate', 'backup', 'snapshot', 'rollback']) but documentation defines choices as ([])
lib/ansible/modules/cloud/misc/proxmox_kvm.py:0:0: E326 Argument 'ostype' in argument_spec defines choices as (['other', 'wxp', 'w2k', 'w2k3', 'w2k8', 'wvista', 'win7', 'win8', 'l24', 'l26', 'solaris']) but documentation defines choices as ([])
lib/ansible/modules/cloud/misc/proxmox_kvm.py:0:0: E326 Argument 'scsihw' in argument_spec defines choices as (['lsi', 'lsi53c810', 'virtio-scsi-pci', 'virtio-scsi-single', 'megasas', 'pvscsi']) but documentation defines choices as ([])
lib/ansible/modules/cloud/misc/proxmox_kvm.py:0:0: E326 Argument 'state' in argument_spec defines choices as (['present', 'absent', 'stopped', 'started', 'restarted', 'current']) but documentation defines choices as ([])
lib/ansible/modules/cloud/misc/proxmox_kvm.py:0:0: E326 Argument 'vga' in argument_spec defines choices as (['std', 'cirrus', 'vmware', 'qxl', 'serial0', 'serial1', 'serial2', 'serial3', 'qxl2', 'qxl3', 'qxl4']) but documentation defines choices as ([])
lib/ansible/modules/cloud/misc/proxmox_kvm.py:282:28: E302 DOCUMENTATION is not valid YAML
test/sanity/validate-modules/ignore.txt:166:1: A102 Remove since "lib/ansible/modules/cloud/misc/proxmox_kvm.py" passes "E322" test

The test ansible-test sanity --test yamllint [explain] failed with 2 errors:

lib/ansible/modules/cloud/misc/proxmox_kvm.py:76:3: key-duplicates DOCUMENTATION: duplication of key "ciuser" in mapping
lib/ansible/modules/cloud/misc/proxmox_kvm.py:282:28: error DOCUMENTATION: syntax error: mapping values are not allowed here

click here for bot help

Tried to fix whitespace issue
Using Github online editor, this isn't obvious
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 20, 2019

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/misc/proxmox_kvm.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/misc/proxmox_kvm.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/misc/proxmox_kvm.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/misc/proxmox_kvm.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/misc/proxmox_kvm.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/cloud/misc/proxmox_kvm.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
PYTHONPATH=../../lib ../bin/dump_config.py --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ -d ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../bin/generate_man.py --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../bin/dump_keywords.py --template-dir=../templates --output-dir=rst/reference_appendices/ -d ./keyword_desc.yml
PYTHONPATH=../../lib ../bin/plugin_formatter.py -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Evaluating module files...
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../bin/plugin_formatter.py", line 783, in <module>
    main()
  File "../bin/plugin_formatter.py", line 738, in main
    plugin_info, categories = get_plugin_info(options.module_dir, limit_to=options.limit_to, verbose=(options.verbosity > 0))
  File "../bin/plugin_formatter.py", line 294, in get_plugin_info
    doc, examples, returndocs, metadata = plugin_docs.get_docstring(module_path, fragment_loader, verbose=verbose)
  File "/root/ansible/lib/ansible/utils/plugin_docs.py", line 105, in get_docstring
    data = read_docstring(filename, verbose=verbose, ignore_errors=ignore_errors)
  File "/root/ansible/lib/ansible/parsing/plugin_docs.py", line 59, in read_docstring
    data[varkey] = AnsibleLoader(child.value.s, file_name=filename).get_single_data()
  File "/usr/local/lib/python3.6/dist-packages/yaml/constructor.py", line 35, in get_single_data
    node = self.get_single_node()
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 36, in get_single_node
    document = self.compose_document()
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 55, in compose_document
    node = self.compose_node(None, None)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 127, in compose_mapping_node
    while not self.check_event(MappingEndEvent):
  File "/usr/local/lib/python3.6/dist-packages/yaml/parser.py", line 98, in check_event
    self.current_event = self.state()
  File "/usr/local/lib/python3.6/dist-packages/yaml/parser.py", line 428, in parse_block_mapping_key
    if self.check_token(KeyToken):
  File "/usr/local/lib/python3.6/dist-packages/yaml/scanner.py", line 116, in check_token
    self.fetch_more_tokens()
  File "/usr/local/lib/python3.6/dist-packages/yaml/scanner.py", line 220, in fetch_more_tokens
    return self.fetch_value()
  File "/usr/local/lib/python3.6/dist-packages/yaml/scanner.py", line 576, in fetch_value
    self.get_mark())
yaml.scanner.ScannerError: mapping values are not allowed here
  in "<unicode string>", line 267, column 28:
        description: Cloud Init: search domain to set for the D ... 
                               ^
make: *** [modules] Error 1

The test ansible-test sanity --test pep8 [explain] failed with 10 errors:

lib/ansible/modules/cloud/misc/proxmox_kvm.py:163:110: W291 trailing whitespace
lib/ansible/modules/cloud/misc/proxmox_kvm.py:472:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/misc/proxmox_kvm.py:490:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/misc/proxmox_kvm.py:507:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/misc/proxmox_kvm.py:639:3: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/misc/proxmox_kvm.py:641:3: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/misc/proxmox_kvm.py:733:15: E124 closing bracket does not match visual indentation
lib/ansible/modules/cloud/misc/proxmox_kvm.py:757:13: E117 over-indented (comment)
lib/ansible/modules/cloud/misc/proxmox_kvm.py:758:13: E117 over-indented (comment)
lib/ansible/modules/cloud/misc/proxmox_kvm.py:763:54: E228 missing whitespace around modulo operator

The test ansible-test sanity --test validate-modules [explain] failed with 10 errors:

lib/ansible/modules/cloud/misc/proxmox_kvm.py:0:0: E326 Argument 'bios' in argument_spec defines choices as (['seabios', 'ovmf']) but documentation defines choices as ([])
lib/ansible/modules/cloud/misc/proxmox_kvm.py:0:0: E326 Argument 'format' in argument_spec defines choices as (['cloop', 'cow', 'qcow', 'qcow2', 'qed', 'raw', 'vmdk']) but documentation defines choices as ([])
lib/ansible/modules/cloud/misc/proxmox_kvm.py:0:0: E326 Argument 'hugepages' in argument_spec defines choices as (['any', '2', '1024']) but documentation defines choices as ([])
lib/ansible/modules/cloud/misc/proxmox_kvm.py:0:0: E326 Argument 'lock' in argument_spec defines choices as (['migrate', 'backup', 'snapshot', 'rollback']) but documentation defines choices as ([])
lib/ansible/modules/cloud/misc/proxmox_kvm.py:0:0: E326 Argument 'ostype' in argument_spec defines choices as (['other', 'wxp', 'w2k', 'w2k3', 'w2k8', 'wvista', 'win7', 'win8', 'l24', 'l26', 'solaris']) but documentation defines choices as ([])
lib/ansible/modules/cloud/misc/proxmox_kvm.py:0:0: E326 Argument 'scsihw' in argument_spec defines choices as (['lsi', 'lsi53c810', 'virtio-scsi-pci', 'virtio-scsi-single', 'megasas', 'pvscsi']) but documentation defines choices as ([])
lib/ansible/modules/cloud/misc/proxmox_kvm.py:0:0: E326 Argument 'state' in argument_spec defines choices as (['present', 'absent', 'stopped', 'started', 'restarted', 'current']) but documentation defines choices as ([])
lib/ansible/modules/cloud/misc/proxmox_kvm.py:0:0: E326 Argument 'vga' in argument_spec defines choices as (['std', 'cirrus', 'vmware', 'qxl', 'serial0', 'serial1', 'serial2', 'serial3', 'qxl2', 'qxl3', 'qxl4']) but documentation defines choices as ([])
lib/ansible/modules/cloud/misc/proxmox_kvm.py:282:28: E302 DOCUMENTATION is not valid YAML
test/sanity/validate-modules/ignore.txt:166:1: A102 Remove since "lib/ansible/modules/cloud/misc/proxmox_kvm.py" passes "E322" test

The test ansible-test sanity --test yamllint [explain] failed with 2 errors:

lib/ansible/modules/cloud/misc/proxmox_kvm.py:76:3: key-duplicates DOCUMENTATION: duplication of key "ciuser" in mapping
lib/ansible/modules/cloud/misc/proxmox_kvm.py:282:28: error DOCUMENTATION: syntax error: mapping values are not allowed here

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 20, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 5 errors:

lib/ansible/modules/cloud/misc/proxmox_kvm.py:0:0: E309 version_added for new option (ciuser) should be '2.8'. Currently StrictVersion ('0.0')
lib/ansible/modules/cloud/misc/proxmox_kvm.py:0:0: E309 version_added for new option (ipconfig) should be '2.8'. Currently StrictVersion ('0.0')
lib/ansible/modules/cloud/misc/proxmox_kvm.py:0:0: E309 version_added for new option (nameserver) should be '2.8'. Currently StrictVersion ('0.0')
lib/ansible/modules/cloud/misc/proxmox_kvm.py:0:0: E309 version_added for new option (searchdomain) should be '2.8'. Currently StrictVersion ('0.0')
lib/ansible/modules/cloud/misc/proxmox_kvm.py:0:0: E309 version_added for new option (sshkeys) should be '2.8'. Currently StrictVersion ('0.0')

click here for bot help

@ansibot ansibot added the ci_verified label Mar 20, 2019

@nuttybrewer

This comment has been minimized.

Copy link
Author

nuttybrewer commented Mar 21, 2019

Just found similar pull request here. Let's merge these together and get the module complete. This is stopping us from adopting ProxMox in our AWX/Tower implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.