Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] openrc module #54115

Open
wants to merge 5 commits into
base: devel
from

Conversation

Projects
None yet
2 participants
@bcoca
Copy link
Member

bcoca commented Mar 20, 2019

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

openrc

@ansibot

This comment was marked as outdated.

Copy link
Contributor

ansibot commented Mar 20, 2019

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/system/openrc.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/system/openrc.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/system/openrc.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/system/openrc.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/system/openrc.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/system/openrc.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
PYTHONPATH=../../lib ../bin/dump_config.py --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ -d ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../bin/generate_man.py --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../bin/dump_keywords.py --template-dir=../templates --output-dir=rst/reference_appendices/ -d ./keyword_desc.yml
PYTHONPATH=../../lib ../bin/plugin_formatter.py -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Evaluating module files...
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../bin/plugin_formatter.py", line 783, in <module>
    main()
  File "../bin/plugin_formatter.py", line 738, in main
    plugin_info, categories = get_plugin_info(options.module_dir, limit_to=options.limit_to, verbose=(options.verbosity > 0))
  File "../bin/plugin_formatter.py", line 294, in get_plugin_info
    doc, examples, returndocs, metadata = plugin_docs.get_docstring(module_path, fragment_loader, verbose=verbose)
  File "/root/ansible/lib/ansible/utils/plugin_docs.py", line 105, in get_docstring
    data = read_docstring(filename, verbose=verbose, ignore_errors=ignore_errors)
  File "/root/ansible/lib/ansible/parsing/plugin_docs.py", line 72, in read_docstring
    del data['metadata'][x]
TypeError: 'str' object does not support item deletion
make: *** [modules] Error 1

The test ansible-test sanity --test validate-modules [explain] failed with 10 errors:

lib/ansible/modules/system/openrc.py:0:0: E304 Unknown DOCUMENTATION error, see TRACE: 'str' object does not support item deletion
lib/ansible/modules/system/openrc.py:0:0: E305 DOCUMENTATION.author: Invalid author for dictionary value @ data['author']. Got ['bcoca']
lib/ansible/modules/system/openrc.py:0:0: E305 DOCUMENTATION.options.enabled.type: not a valid value for dictionary value @ data['options']['enabled']['type']. Got 'boolean'
lib/ansible/modules/system/openrc.py:0:0: E305 DOCUMENTATION.options.sleep.type: not a valid value for dictionary value @ data['options']['sleep']['type']. Got 'integer'
lib/ansible/modules/system/openrc.py:0:0: E307 version_added should be '2.8'. Currently '2.9'
lib/ansible/modules/system/openrc.py:0:0: E315 ANSIBLE_METADATA was not provided as a dict, YAML not supported
lib/ansible/modules/system/openrc.py:0:0: E324 Argument 'runlevels' in argument_spec defines default as (None) but documentation defines default as (['default'])
lib/ansible/modules/system/openrc.py:0:0: E325 Argument 'enabled' in argument_spec defines type as 'bool' but documentation defines type as 'boolean'
lib/ansible/modules/system/openrc.py:0:0: E325 Argument 'sleep' in argument_spec defines type as 'int' but documentation defines type as 'integer'
lib/ansible/modules/system/openrc.py:0:0: E326 Argument 'state' in argument_spec defines choices as (['started', 'stopped', 'restarted', 'reloaded']) but documentation defines choices as (['started', 'stopped', 'restarted', 'reloaded', 'paused'])

click here for bot help

@ansibot

This comment was marked as outdated.

Copy link
Contributor

ansibot commented Mar 20, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 9 errors:

lib/ansible/modules/system/openrc.py:0:0: E305 DOCUMENTATION.author: Invalid author for dictionary value @ data['author']. Got ['bcoca']
lib/ansible/modules/system/openrc.py:0:0: E305 DOCUMENTATION.options.enabled.type: not a valid value for dictionary value @ data['options']['enabled']['type']. Got 'boolean'
lib/ansible/modules/system/openrc.py:0:0: E305 DOCUMENTATION.options.sleep.type: not a valid value for dictionary value @ data['options']['sleep']['type']. Got 'integer'
lib/ansible/modules/system/openrc.py:0:0: E307 version_added should be '2.8'. Currently '2.9'
lib/ansible/modules/system/openrc.py:0:0: E314 No ANSIBLE_METADATA provided
lib/ansible/modules/system/openrc.py:0:0: E324 Argument 'runlevels' in argument_spec defines default as (None) but documentation defines default as (['default'])
lib/ansible/modules/system/openrc.py:0:0: E325 Argument 'enabled' in argument_spec defines type as 'bool' but documentation defines type as 'boolean'
lib/ansible/modules/system/openrc.py:0:0: E325 Argument 'sleep' in argument_spec defines type as 'int' but documentation defines type as 'integer'
lib/ansible/modules/system/openrc.py:0:0: E326 Argument 'state' in argument_spec defines choices as (['started', 'stopped', 'restarted', 'reloaded']) but documentation defines choices as (['started', 'stopped', 'restarted', 'reloaded', 'paused'])

click here for bot help

@ansibot ansibot added the ci_verified label Mar 20, 2019

@ansibot ansibot removed the ci_verified label Mar 20, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 20, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/system/openrc.py:0:0: E305 DOCUMENTATION.author: Invalid author for dictionary value @ data['author']. Got ['bcoca']
lib/ansible/modules/system/openrc.py:0:0: E307 version_added should be '2.8'. Currently '2.9'
lib/ansible/modules/system/openrc.py:0:0: E314 No ANSIBLE_METADATA provided

click here for bot help

@ansibot ansibot added the ci_verified label Mar 20, 2019

@ansibot ansibot added the stale_ci label Mar 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.