Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMware: Python 3 related TypeError #54123

Open
wants to merge 3 commits into
base: devel
from

Conversation

Projects
None yet
5 participants
@agowa338
Copy link
Contributor

agowa338 commented Mar 20, 2019

SUMMARY

TypeError within the vmware_guest module

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vmware_guest

ADDITIONAL INFORMATION

Fixes #54118 (and also remove white spaces from the hostname)

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 20, 2019

@agowa338, just so you are aware we have a dedicated Working Group for vmware.
You can find other people interested in this in #ansible-vmware on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@kobayashi

This comment has been minimized.

Copy link
Contributor

kobayashi commented Mar 23, 2019

That must be working but a little bit complicated.
Why not just replace to default_name = self.params['name'].translate(str.maketrans('', '', string.punctuation)?

@jillr
Copy link
Contributor

jillr left a comment

Could you please try to simplify this code? @kobayashi had a good suggestion to consider.

@agowa338 agowa338 closed this Mar 25, 2019

@agowa338 agowa338 force-pushed the agowa338:patch-1 branch to 6b00d4d Mar 25, 2019

@agowa338 agowa338 reopened this Mar 25, 2019

agowa338 added some commits Mar 20, 2019

Fix python 3 incompatibility
Fixes #54118 (and also remove white spaces from the hostname)

@agowa338 agowa338 force-pushed the agowa338:patch-1 branch to bbb0fdf Mar 25, 2019

@Akasurde

This comment has been minimized.

Copy link
Member

Akasurde commented Mar 26, 2019

@Tomorrow9 Could you please comment on this change ? Thanks.

Revert "Use kobayashi's alternative"
As python2 compatibilty is now broken.

This reverts commit bbb0fdf.
@agowa338

This comment has been minimized.

Copy link
Contributor Author

agowa338 commented Mar 27, 2019

I reverted the suggested implementation of @kobayashi, as that causes incompatibility with python2.
If anyone knows a cleaner implementation that works with python2 and python3, I'm happy to swap it. But this is the cleanest implementation that works with python2 and python3 that I could think off.

@ansibot ansibot removed the small_patch label Mar 27, 2019

@kobayashi

This comment has been minimized.

Copy link
Contributor

kobayashi commented Mar 29, 2019

Yes, my suggestion only focused on python3. @agowa338 's original is better for compatibility.
Thank you for the suggestion. :shipit:

@ansibot ansibot added the stale_ci label Apr 6, 2019

@ansibot ansibot added the stale_review label Apr 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.