Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cloudwatchevent_rule] convert task_count #54219

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
2 participants
@pha6d
Copy link

pha6d commented Mar 22, 2019

allows easier usage of jinja2 templating for task_count

SUMMARY

Underneath dependencies aren't accepting str as acceptable type for task_count and Jinja2 templating often ends with a str.
Here we're trying to use the given input assuming its type is of type int or long, otherwise attends to convert it.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

module cloudwatchevent_rule / cloudwatchevent_rule.py

[cloudwatchevent_rule] convert task_count
allows easier usage of jinja2 templating for task_count
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 22, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 22, 2019

@pha6d, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 22, 2019

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/modules/cloud/amazon/cloudwatchevent_rule.py:277:143: undefined-variable Undefined variable 'long'
lib/ansible/modules/cloud/amazon/cloudwatchevent_rule.py:277:154: undefined-variable Undefined variable 'long'

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/cloudwatchevent_rule.py:277:161: E501 line too long (188 > 160 characters)

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/cloudwatchevent_rule.py:277:0: E403 Type comparison using type() found. Use isinstance() instead

click here for bot help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.