Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add example how to use aws_service_ip_ranges result in ec2_group module #54232

Open
wants to merge 12 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@markuman
Copy link

commented Mar 22, 2019

SUMMARY

I add an example how to use the output of lookup plugin aws_service_ip_ranges with the ec2_group module.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

plugins/lookup/aws_service_ip_ranges.py

ADDITIONAL INFORMATION
  1. fetch the raw data using aws_service_ip_ranges
  2. prepare a list structure which can be used in ec2_group module
  3. apply the ip ranges from 1 in a security group using ec2_group
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/plugins/lookup/aws_service_ip_ranges.py:40:19: error EXAMPLES: syntax error: mapping values are not allowed here

click here for bot help

@acozine

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

Thanks @markuman for submitting this change. The Examples section of a module's documentation usually only shows tasks that use that module. Here you're using other modules, and the example tasks must be used together.

To make this clear, could you either:

  1. Format the tasks as a block, so it's obvious they cannot be used separately, or
  2. Add this example to the AWS guide instead of to the module documentation

Thanks!

@acozine acozine removed the needs_triage label Apr 15, 2019

@markuman

This comment has been minimized.

Copy link
Author

commented Apr 21, 2019

@acozine I've revert the changes in the lookup plugin and add a new section in the aws guide.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 21, 2019

@markuman this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 21, 2019

@markuman this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@acozine

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2019

Thanks @markuman for updating your PR. Unfortunately some merge commits were introduced - can you rebase the branch so it only contains your changes to the AWS guide?

@markuman

This comment has been minimized.

Copy link
Author

commented Apr 23, 2019

@markuman

This comment has been minimized.

Copy link
Author

commented Apr 23, 2019

...and I already did a rebase because told me to do so because of commit 3ba2b78.
The result is that ansibot told me again to rebase again because of commit 3ba2b78 and a 2nd commit 7b65829

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.