Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meraki_switchport - Improve reliability #54275

Open
wants to merge 4 commits into
base: devel
from

Conversation

Projects
None yet
2 participants
@kbreit
Copy link
Contributor

commented Mar 23, 2019

SUMMARY

meraki_switchport wasn't very reliable when it came to the allowed_vlans statement. These changes are a significant rewrite of the logic to make this work.

Additionally, payload creation was simplified.

Fixes #53601

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

meraki_switchport

kbreit added some commits Mar 22, 2019

Rewrite much of the execution of meraki_switchport
- Previous versions had problems with idempotency and allowed_vlans
Modified payload creation
- Parameter map is used
- propsed is created using .copy()
- Much cleaner this way
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Mar 23, 2019

@ansibot ansibot added the stale_ci label Mar 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.