Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add os_address_scope module #54286

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
2 participants
@dariko
Copy link
Contributor

dariko commented Mar 23, 2019

SUMMARY

This PR adds a new os_address_scope module to manage openstack address scopes.

ISSUE TYPE
  • New Module Pull Request
ADDITIONAL INFORMATION

This module requires the address scope name to be unique cloud-wide.
This module can be used to create and update address scopes, following the Neutron v2 API:

  • shared can only be changed from false to true.
  • ip_version and project_id cannot be updated.
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 23, 2019

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_address_scope.py:0:0: missing documentation (or could not parse documentation): 'description'

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_address_scope.py:0:0: missing documentation (or could not parse documentation): 'description'

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_address_scope.py:0:0: missing documentation (or could not parse documentation): 'description'

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_address_scope.py:0:0: missing documentation (or could not parse documentation): 'description'

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_address_scope.py:0:0: missing documentation (or could not parse documentation): 'description'

The test ansible-test sanity --test ansible-doc --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_address_scope.py:0:0: missing documentation (or could not parse documentation): 'description'

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
PYTHONPATH=../../lib ../bin/dump_config.py --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ -d ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../bin/generate_man.py --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../bin/dump_keywords.py --template-dir=../templates --output-dir=rst/reference_appendices/ -d ./keyword_desc.yml
PYTHONPATH=../../lib ../bin/plugin_formatter.py -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Evaluating module files...
rendering: os_auth (2387 previous rendering line(s) omitted)
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../bin/plugin_formatter.py", line 783, in <module>
    main()
  File "../bin/plugin_formatter.py", line 770, in main
    process_plugins(plugin_info, templates, outputname, output_dir, options.ansible_version, plugin_type)
  File "../bin/plugin_formatter.py", line 503, in process_plugins
    raise AnsibleError("Missing required description for parameter '%s' in '%s' " % (k, module))
ansible.errors.AnsibleError: Missing required description for parameter 'state' in 'os_address_scope' 
make: *** [modules] Error 1

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/cloud/openstack/os_address_scope.py:0:0: E305 DOCUMENTATION.author: Invalid author for dictionary value @ data['author']. Got 'Dario Zanzico'
lib/ansible/modules/cloud/openstack/os_address_scope.py:0:0: E305 DOCUMENTATION.options.state.description: required key not provided @ data['options']['state']['description']. Got None
lib/ansible/modules/cloud/openstack/os_address_scope.py:0:0: E322 Argument 'availability_zone' is listed in the argument_spec, but not documented in the module documentation

click here for bot help

@dariko dariko force-pushed the dariko:os_address_scope_module branch to a6fb587 Mar 23, 2019

@dariko

This comment has been minimized.

Copy link
Contributor Author

dariko commented Mar 23, 2019

This is the playbook I used to test the module

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 23, 2019

@SamYaple @agireud @albertomurillo @bennojoy @cloudnull @dagnello @dguerri @evrardjp @flwang @haneefs @ioggstream @juliakreger @Kong @kuboj @lingxiankong @matbu @mgale @mnaser @odyssey4me @omgjlk @ruizink @steveb

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@openstack-zuul

This comment has been minimized.

Copy link

openstack-zuul bot commented Mar 23, 2019

Build succeeded (third-party-check pipeline).

@dariko

This comment has been minimized.

Copy link
Contributor Author

dariko commented Mar 23, 2019

While writing this module I thought about how to write some integration tests but I quickly gave up considering the problem scope. Then I noticed the openstack/third-party-check check being executed on this PR, and in its logs I saw that a devstack installation had been instantiated and some tests had been executed against it.

I think I found those tests the openstacksdk repository and consequently that submitting code to that repository should be done following the openstack developer workflow, is this correct?

@ansibot ansibot added the stale_ci label Mar 31, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Apr 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.