Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMware: Create vmware_folder_info #54344

Open
wants to merge 4 commits into
base: devel
from

Conversation

@davidmhewitt
Copy link

davidmhewitt commented Mar 25, 2019

SUMMARY

Adds a new vmware module to support getting the folders and their paths within a datacenter

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

vmware_folder_info

ADDITIONAL INFORMATION

This is useful in workflows where ansible is being driven from a UI of some sort and we need to prompt the user to choose a folder. If we can gather a hierarchical list of folders, this can be used to populate the UI.

Create vmware_folder_facts
Adds a new vmware module to support getting the folders and their paths within a datacenter
@sivel
Copy link
Member

sivel left a comment

This module should use a suffix of _info instead of _facts. See ansible/community#346 (comment)

Note: I have not reviewed any other aspect of this submission.

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 25, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_folder_facts.py:143:19: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

lib/ansible/modules/cloud/vmware/vmware_folder_facts.py:105:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/vmware/vmware_folder_facts.py:128:19: E203 whitespace before ':'
lib/ansible/modules/cloud/vmware/vmware_folder_facts.py:143:20: W291 trailing whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/cloud/vmware/vmware_folder_facts.py:0:0: E322 Argument 'datacenter_name' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/vmware/vmware_folder_facts.py:140:0: E403 Type comparison using type() found. Use isinstance() instead

click here for bot help

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 25, 2019

@davidmhewitt, just so you are aware we have a dedicated Working Group for vmware.
You can find other people interested in this in #ansible-vmware on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@davidmhewitt davidmhewitt changed the title Create vmware_folder_facts Create vmware_folder_info Mar 25, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 25, 2019

@GBrawl @MikeKlebolt @Tomorrow9 @Akasurde @alongchamps @bedecarroll @CastawayEGR @chrrrles @dav1x @garbled1 @gyorgypeter @imjoseangel @jjahns @kamsz @karstenjakobsen @kryptsi @lrivallain @michaeldeaton @nafpliot-ibm @nerzhul @oboukili @rhoop @ritzk @rmin @stravassac @sumkincpp @vmwjoseph @warthog9 @woshihaoren

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@Akasurde Akasurde self-assigned this Mar 25, 2019

@Akasurde Akasurde changed the title Create vmware_folder_info VMware: Create vmware_folder_info Mar 25, 2019

@Akasurde

This comment has been minimized.

Copy link
Member

Akasurde commented Mar 25, 2019

@davidmhewitt Thanks for the PR. Could you please write an integration test for this change ? You can check - https://github.com/ansible/ansible/tree/devel/test/integration/targets/vmware_guest_facts as reference.

@davidmhewitt davidmhewitt force-pushed the davidmhewitt:patch-1 branch to 7ee1185 Mar 26, 2019

@davidmhewitt

This comment has been minimized.

Copy link
Author

davidmhewitt commented Mar 26, 2019

Thank you for the pointer. Integration tests added

ready_for_review

@davidmhewitt

This comment has been minimized.

Copy link
Author

davidmhewitt commented Apr 1, 2019

@Akasurde I see you assigned yourself as the reviewer on this. Would it be possible for you to take another look?

I'm aware the change freeze is coming up for new modules soon, so I'd be very grateful to get some feedback on this. I'd be happy to make any quick revisions if necessary.

@Akasurde Akasurde requested review from jillr and goneri Apr 14, 2019

The change has been done.

@ansibot ansibot removed the stale_review label Apr 15, 2019

@goneri

goneri approved these changes Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.