Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified lvol.py to accept '+' on absolute values #54402

Open
wants to merge 10 commits into
base: devel
from

Conversation

Projects
None yet
2 participants
@unkaputtbar112
Copy link

unkaputtbar112 commented Mar 26, 2019

... also added simple recalculations from e.g. MebiByte to MegaByte (for Kilo, Giga, Terra,...) to have consistency between lvs --units M/m and given Size M/m to lvextend (K/k, G/g, E/e, ...)

SUMMARY

Fixes #54092
"Fixes" #37599
Fixes #29313

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lvol

ADDITIONAL INFORMATION

Raoul Baudach added some commits Mar 26, 2019

Raoul Baudach
Modified lvol.py to accept '+' on absolute values, also added simple …
…recalculations from e.g. MebiByte to MegaByte (for Kilo, Giga, Terra,...) to have consistence between lvs --units M/m and given Size M/m (K/k, G/g, E/e, ...)
Raoul Baudach
Raoul Baudach
Raoul Baudach
Raoul Baudach
fix
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 26, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 26, 2019

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/modules/system/lvol.py:445:0: syntax-error positional argument follows keyword argument (<unknown>, line 445)
test/sanity/pylint/ignore.txt:65:1: A102 Remove since "lib/ansible/modules/system/lvol.py" passes "blacklisted-name" pylint test

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/system/lvol.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/system/lvol.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/system/lvol.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/system/lvol.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/system/lvol.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/system/lvol.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
PYTHONPATH=../../lib ../bin/dump_config.py --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ -d ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../bin/generate_man.py --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../bin/dump_keywords.py --template-dir=../templates --output-dir=rst/reference_appendices/ -d ./keyword_desc.yml
PYTHONPATH=../../lib ../bin/plugin_formatter.py -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Evaluating module files...
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../bin/plugin_formatter.py", line 783, in <module>
    main()
  File "../bin/plugin_formatter.py", line 738, in main
    plugin_info, categories = get_plugin_info(options.module_dir, limit_to=options.limit_to, verbose=(options.verbosity > 0))
  File "../bin/plugin_formatter.py", line 294, in get_plugin_info
    doc, examples, returndocs, metadata = plugin_docs.get_docstring(module_path, fragment_loader, verbose=verbose)
  File "/root/ansible/lib/ansible/utils/plugin_docs.py", line 105, in get_docstring
    data = read_docstring(filename, verbose=verbose, ignore_errors=ignore_errors)
  File "/root/ansible/lib/ansible/parsing/plugin_docs.py", line 40, in read_docstring
    M = ast.parse(b_module_data.read())
  File "/usr/lib/python3.6/ast.py", line 35, in parse
    return compile(source, filename, mode, PyCF_ONLY_AST)
  File "<unknown>", line 445
SyntaxError: positional argument follows keyword argument
make: *** [modules] Error 1

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/system/lvol.py:445:0: SyntaxError: non-keyword arg after keyword arg

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/system/lvol.py:445:0: SyntaxError: non-keyword arg after keyword arg

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/system/lvol.py:445:105: SyntaxError: positional argument follows keyword argument

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/system/lvol.py:445:105: SyntaxError: positional argument follows keyword argument

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/system/lvol.py:445:105: SyntaxError: positional argument follows keyword argument

The test ansible-test sanity --test import --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/system/lvol.py:445:106: SyntaxError: positional argument follows keyword argument

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/system/lvol.py:0:0: E401 Python SyntaxError while parsing module

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/system/lvol.py:445:105: python-syntax-error positional argument follows keyword argument (<unknown>, line 445)

click here for bot help

Raoul Baudach added some commits Mar 27, 2019

Raoul Baudach
Raoul Baudach
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.