Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws_s3] fix deleting versioned objects before deleting bucket #54435

Open

Conversation

Projects
None yet
3 participants
@s-hertel
Copy link
Contributor

commented Mar 26, 2019

SUMMARY

Prior to this fix the latest objects are deleted from a bucket but the versioned markers are left behind, causing a traceback when deleting the bucket.

Generating the list of keys and deleted version markers from list_object_versions works both for versioned and non-versioned buckets. I kept the original attempt via list_objects_v2 in case of permissions errors or S3 drop-ins without versioning support.

Fixes #53536

@willthames Do you mind taking a look at this? It seems like a foot gun that people could delete a bucket containing versioned objects accidentally. But since object locks can prevent that I'm not sure. Thoughts?

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

aws_s3

@s-hertel s-hertel requested a review from willthames Mar 27, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

s-hertel added some commits Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.