Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os_ironic_node: avoid set_node_instance_info and purge_node_instance_info #54463

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
4 participants
@dtantsur
Copy link

dtantsur commented Mar 27, 2019

SUMMARY

These openstacksdk calls are awkward special-case wrappers around
patch_machine, and I would like to deprecate them in openstacksdk change
https://review.openstack.org/647730. Use much simpler update_machine instead.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

os_ironic_node

ADDITIONAL INFORMATION
os_ironic_node: avoid set_node_instance_info and purge_node_instance_…
…info

These openstacksdk calls are awkward special-case wrappers around
patch_machine, and I would like to deprecate them in openstacksdk change
https://review.openstack.org/647730. Use much simpler update_machine instead.
@openstack-zuul

This comment has been minimized.

Copy link

openstack-zuul bot commented Mar 27, 2019

Build succeeded (third-party-check pipeline).

@juliakreger
Copy link
Contributor

juliakreger left a comment

LGTM, Thanks Dmitry!

@ansibot ansibot removed the needs_triage label Mar 27, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Apr 4, 2019

@ansibot ansibot added the stale_ci label Apr 4, 2019

@gtema

gtema approved these changes Apr 5, 2019

Copy link
Contributor

gtema left a comment

shipit

@gtema

This comment has been minimized.

Copy link
Contributor

gtema commented Apr 5, 2019

recheck

@openstack-zuul

This comment has been minimized.

Copy link

openstack-zuul bot commented Apr 5, 2019

Build succeeded (third-party-check pipeline).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.