Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Some getent databases allow for duplicate records #54525

Open
wants to merge 3 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@sivel
Copy link
Member

commented Mar 28, 2019

SUMMARY

Some getent databases allow for duplicate records, ensure we combine, rather than overwrite

Fixes #54488

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/system/getent.py

ADDITIONAL INFORMATION

@sivel sivel requested a review from bcoca Mar 28, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

@sivel sivel changed the title Some getent databases allow for duplicate records [WIP] Some getent databases allow for duplicate records Mar 28, 2019

@sivel

This comment has been minimized.

Copy link
Member Author

commented Mar 28, 2019

Ok, this will need a little more work. We cannot use set as it will eliminate necessary duplicates.

@bcoca

This comment has been minimized.

Copy link
Member

commented Mar 28, 2019

i have slight recollection that dropping dupes was done on purpose, need to check the history to confirm

@ansibot ansibot added WIP and removed needs_triage labels Mar 28, 2019

@sivel

This comment has been minimized.

Copy link
Member Author

commented Mar 28, 2019

It may be that some databases don't allow them, but others do. But getent itself provides no indication of which support it.

I only know that hosts will work with duplicates.

However with what I have right now, if we found a duplicate in something like /etc/passwd it could end up weird.

Maybe we have to add special casing to allowing dupes.

@ansibot ansibot added the stale_ci label Apr 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.