Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canonicalize Gluster peer host names #54544

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
3 participants
@dgadmin
Copy link
Contributor

commented Mar 28, 2019

SUMMARY

By default, gluster_volume module checks hosts in arguments against hosts already in the cluster using simple string comparison. This doesn't work consistently when not using FQDNs (even then, this might be inconsistent when CNAMEs are used).

For example, alpha.example.net may or may not be printed in gluster(8) output as alpha. This patch ensures consistent behavior by using getaddrinfo(3) to canonicalize host names. Correct behavior confirmed under Python 2 and 3.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

gluster_volume

Canonicalize Gluster peer host names
Use getaddrinfo(3) to canonicalize host names of the peers, instead of
relying on string comparison. For example, "alpha.example.net" may or
may not printed in gluster(8) output as "alpha". This patch ensures
consistent behavior.
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.