Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add $team_bitbucket to BOTMETA #54595

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@dagwieers
Copy link
Member

commented Mar 29, 2019

SUMMARY

Add bitbucket maintainers to all bitbucket-related material.

This requires #54599

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

bitbucket

@dagwieers dagwieers added the bitbucket label Mar 29, 2019

@dagwieers dagwieers requested a review from gundalow Mar 29, 2019

@dagwieers

This comment has been minimized.

Copy link
Member Author

commented Mar 29, 2019

@zyv Is this correct ?

@ansibot

This comment was marked as outdated.

Copy link
Contributor

commented Mar 29, 2019

The test ansible-test sanity --test botmeta [explain] failed with 1 error:

.github/BOTMETA.yml:0:0: Can't find 'test/units/modules/source_control/bitbucket.*' in this branch

click here for bot help

@ansibot ansibot removed the ci_verified label Mar 29, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

The test ansible-test sanity --test botmeta [explain] failed with 1 error:

.github/BOTMETA.yml:0:0: Can't find 'test/units/modules/source_control/bitbucket.*' in this branch

click here for bot help

@ansibot ansibot added the ci_verified label Mar 29, 2019

@zyv

zyv approved these changes Mar 29, 2019

Copy link
Contributor

left a comment

Great, thank you @dagwieers!

@@ -1391,6 +1393,8 @@ files:
test/units/modules/network/iosxr: *iosxr
test/units/modules/network/nso: *nso
test/units/modules/network/nxos: *nxos
test/units/modules/source_control/bitbucket: $team_bitbucket

This comment has been minimized.

Copy link
@gundalow

gundalow Mar 29, 2019

Contributor

Unit tests need moving https://github.com/ansible/ansible/tree/devel/test/units/modules/source_control to match where modules are, ie into /bitbucket/

This comment has been minimized.

Copy link
@dagwieers

dagwieers Apr 1, 2019

Author Member

This requires #54599

@ansibot ansibot added the stale_ci label Apr 9, 2019

@gundalow gundalow removed the docs label Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.