Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]vmware: move get_folder() in module_utils #54620

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
3 participants
@goneri
Copy link
Contributor

goneri commented Mar 29, 2019

  • Move get_folder() from vcenter_folder.py in the module_utils module.
  • Reuse it in vmware_guest.py and vmware_host.py
SUMMARY

Minor re-factoring of the code base used to find the folders.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • vmware
ADDITIONAL INFORMATION

WIP because the patch has not been tested enough.

vmware: move get_folder() in module_utils
- Move `get_folder()` from `vcenter_folder.py` in the module_utils module.
- Reuse it in `vmware_guest.py` and `vmware_host.py`
@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 29, 2019

@goneri, just so you are aware we have a dedicated Working Group for vmware.
You can find other people interested in this in #ansible-vmware on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 29, 2019

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/module_utils/vmware.py:1395:5: E303 too many blank lines (2)
lib/ansible/modules/cloud/vmware/vcenter_folder.py:285:1: E303 too many blank lines (3)

click here for bot help

@Akasurde Akasurde self-assigned this Apr 5, 2019

@Akasurde Akasurde removed the needs_triage label Apr 5, 2019

@ansibot ansibot added the stale_ci label Apr 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.