Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2_eni: refresh local view of eni after adding secondary IPs #54630

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@jeking3
Copy link
Contributor

jeking3 commented Mar 30, 2019

  • added integration test to prove the error no longer exists
SUMMARY

When specifying secondary_private_ip_address_count the results would only have the primary address.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_eni

ADDITIONAL INFORMATION

Asking for 4 IPs:
before

            "private_ip_addresses": [
                {
                    "primary_address": true,
                    "private_ip_address": "10.232.232.133"
                }
            ],

after

            "private_ip_addresses": [
                {
                    "primary_address": true,
                    "private_ip_address": "10.232.232.133"
                },
                {
                    "primary_address": false,
                    "private_ip_address": "10.232.232.137"
                },
                {
                    "primary_address": false,
                    "private_ip_address": "10.232.232.142"
                },
                {
                    "primary_address": false,
                    "private_ip_address": "10.232.232.134"
                }
            ],
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 30, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 30, 2019

@jeking3, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@jeking3

This comment has been minimized.

Copy link
Contributor Author

jeking3 commented Mar 30, 2019

@Akasurde the error is "You are not authorized to perform this operation." - I don't know how to fix this in your CI environment.

ec2_eni: refresh local view of eni after adding secondary IPs
- added integration test to prove the error no longer exists

@jeking3 jeking3 force-pushed the jeking3:ec2_eni_secondary branch to bc2e107 Apr 1, 2019

@jeking3

This comment has been minimized.

Copy link
Contributor Author

jeking3 commented Apr 1, 2019

This now passes clean and deletes everything it creates when I run the integration test.

@jeking3

This comment has been minimized.

Copy link
Contributor Author

jeking3 commented Apr 4, 2019

@Akasurde the error is "You are not authorized to perform this operation." - I don't know how to fix this in your CI environment.

@jeking3

This comment has been minimized.

Copy link
Contributor Author

jeking3 commented Apr 5, 2019

Thanks @mattclay - is there anything I can do to fix that issue or no?

@mattclay

This comment has been minimized.

Copy link
Member

mattclay commented Apr 5, 2019

@jeking3 No, the permissions update is something we'll have to do in our CI system. There's a backlog of PRs needing CI permissions changes, so I don't know how soon we'll be able to support the tests.

@jeking3

This comment has been minimized.

Copy link
Contributor Author

jeking3 commented Apr 22, 2019

Closing in favor of #54950

@jeking3 jeking3 closed this Apr 22, 2019

@jeking3 jeking3 deleted the jeking3:ec2_eni_secondary branch Apr 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.