Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dms endpoint module #54660

Merged
merged 40 commits into from Apr 18, 2019

Conversation

Projects
None yet
6 participants
@ruimoreira
Copy link
Contributor

commented Mar 31, 2019

SUMMARY

Added new module for AWS Data migration service endpoints

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

dms_endpoint

ADDITIONAL INFORMATION

This module can be used to manage

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Mar 31, 2019

The test ansible-test sanity --test pylint [explain] failed with 4 errors:

lib/ansible/modules/cloud/amazon/dms_endpoint.py:152:4: bare-except No exception type(s) specified
lib/ansible/modules/cloud/amazon/dms_endpoint.py:235:4: bare-except No exception type(s) specified
lib/ansible/modules/cloud/amazon/dms_endpoint.py:324:4: bare-except No exception type(s) specified
lib/ansible/modules/cloud/amazon/dms_endpoint.py:344:4: bare-except No exception type(s) specified

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python3.6 test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
PYTHONPATH=../../lib ../bin/dump_config.py --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ -d ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../bin/generate_man.py --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../bin/dump_keywords.py --template-dir=../templates --output-dir=rst/reference_appendices/ -d ./keyword_desc.yml
PYTHONPATH=../../lib ../bin/plugin_formatter.py -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Evaluating module files...
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../bin/plugin_formatter.py", line 783, in <module>
    main()
  File "../bin/plugin_formatter.py", line 738, in main
    plugin_info, categories = get_plugin_info(options.module_dir, limit_to=options.limit_to, verbose=(options.verbosity > 0))
  File "../bin/plugin_formatter.py", line 294, in get_plugin_info
    doc, examples, returndocs, metadata = plugin_docs.get_docstring(module_path, fragment_loader, verbose=verbose)
  File "/root/ansible/lib/ansible/utils/plugin_docs.py", line 105, in get_docstring
    data = read_docstring(filename, verbose=verbose, ignore_errors=ignore_errors)
  File "/root/ansible/lib/ansible/parsing/plugin_docs.py", line 59, in read_docstring
    data[varkey] = AnsibleLoader(child.value.s, file_name=filename).get_single_data()
  File "/usr/local/lib/python3.6/dist-packages/yaml/constructor.py", line 41, in get_single_data
    node = self.get_single_node()
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 36, in get_single_node
    document = self.compose_document()
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 55, in compose_document
    node = self.compose_node(None, None)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 127, in compose_mapping_node
    while not self.check_event(MappingEndEvent):
  File "/usr/local/lib/python3.6/dist-packages/yaml/parser.py", line 98, in check_event
    self.current_event = self.state()
  File "/usr/local/lib/python3.6/dist-packages/yaml/parser.py", line 439, in parse_block_mapping_key
    "expected <block end>, but found %r" % token.id, token.start_mark)
yaml.parser.ParserError: while parsing a block mapping
  in "<unicode string>", line 17, column 7:
          description:
          ^
expected <block end>, but found '<block mapping start>'
  in "<unicode string>", line 19, column 8:
           choices: ['source', 'target'] 
           ^
make: *** [modules] Error 1

The test ansible-test sanity --test integration-aliases [explain] failed with 1 error:

test/integration/targets/dms_endpoint/aliases:0:0: missing alias `shippable/aws/group[1-2]` or `unsupported`

The test ansible-test sanity --test pep8 [explain] failed with 26 errors:

lib/ansible/modules/cloud/amazon/dms_endpoint.py:24:11: W291 trailing whitespace
lib/ansible/modules/cloud/amazon/dms_endpoint.py:26:32: W291 trailing whitespace
lib/ansible/modules/cloud/amazon/dms_endpoint.py:27:23: W291 trailing whitespace
lib/ansible/modules/cloud/amazon/dms_endpoint.py:30:46: W291 trailing whitespace
lib/ansible/modules/cloud/amazon/dms_endpoint.py:34:37: W291 trailing whitespace
lib/ansible/modules/cloud/amazon/dms_endpoint.py:40:61: W291 trailing whitespace
lib/ansible/modules/cloud/amazon/dms_endpoint.py:50:10: W291 trailing whitespace
lib/ansible/modules/cloud/amazon/dms_endpoint.py:55:61: W291 trailing whitespace
lib/ansible/modules/cloud/amazon/dms_endpoint.py:57:19: W291 trailing whitespace
lib/ansible/modules/cloud/amazon/dms_endpoint.py:58:161: E501 line too long (194 > 160 characters)
lib/ansible/modules/cloud/amazon/dms_endpoint.py:62:10: W291 trailing whitespace
lib/ansible/modules/cloud/amazon/dms_endpoint.py:93:84: W291 trailing whitespace
lib/ansible/modules/cloud/amazon/dms_endpoint.py:103:11: W291 trailing whitespace
lib/ansible/modules/cloud/amazon/dms_endpoint.py:105:94: W291 trailing whitespace
lib/ansible/modules/cloud/amazon/dms_endpoint.py:133:1: E303 too many blank lines (3)
lib/ansible/modules/cloud/amazon/dms_endpoint.py:138:5: E265 block comment should start with '# '
lib/ansible/modules/cloud/amazon/dms_endpoint.py:152:5: E722 do not use bare 'except'
lib/ansible/modules/cloud/amazon/dms_endpoint.py:190:1: E265 block comment should start with '# '
lib/ansible/modules/cloud/amazon/dms_endpoint.py:204:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/amazon/dms_endpoint.py:235:5: E722 do not use bare 'except'
lib/ansible/modules/cloud/amazon/dms_endpoint.py:306:67: E272 multiple spaces before keyword
lib/ansible/modules/cloud/amazon/dms_endpoint.py:313:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/amazon/dms_endpoint.py:324:5: E722 do not use bare 'except'
lib/ansible/modules/cloud/amazon/dms_endpoint.py:328:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/amazon/dms_endpoint.py:344:5: E722 do not use bare 'except'
lib/ansible/modules/cloud/amazon/dms_endpoint.py:419:1: E303 too many blank lines (3)

The test ansible-test sanity --test validate-modules [explain] failed with 11 errors:

lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: E312 No RETURN provided
lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: E324 Argument 'sslmode' in argument_spec defines default as ('none') but documentation defines default as (None)
lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: E324 Argument 'state' in argument_spec defines default as ('present') but documentation defines default as (None)
lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: E324 Argument 'validate_certs' in argument_spec defines default as (True) but documentation defines default as (False)
lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: E326 Argument 'endpointtype' in argument_spec defines choices as (['source', 'target']) but documentation defines choices as ([])
lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: E326 Argument 'enginename' in argument_spec defines choices as (['mysql', 'oracle', 'postgres', 'mariadb', 'aurora', 'redshift', 's3', 'db2', 'azuredb', 'sybase', 'dynamodb', 'mongodb', 'sqlserver']) but documentation defines choices as ([])
lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: E326 Argument 'sslmode' in argument_spec defines choices as (['none', 'require', 'verify-ca', 'verify-full']) but documentation defines choices as ([])
lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: E326 Argument 'state' in argument_spec defines choices as (['present', 'absent']) but documentation defines choices as ([])
lib/ansible/modules/cloud/amazon/dms_endpoint.py:6:0: E106 Import found before documentation variables. All imports must appear below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.
lib/ansible/modules/cloud/amazon/dms_endpoint.py:6:0: E107 Imports should be directly below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.
lib/ansible/modules/cloud/amazon/dms_endpoint.py:34:8: E302 DOCUMENTATION is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dms_endpoint.py:34:8: error DOCUMENTATION: syntax error: expected <block end>, but found '<block mapping start>'

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Mar 31, 2019

@ruimoreira, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Mar 31, 2019

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python3.6 test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
PYTHONPATH=../../lib ../bin/dump_config.py --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ -d ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../bin/generate_man.py --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../bin/dump_keywords.py --template-dir=../templates --output-dir=rst/reference_appendices/ -d ./keyword_desc.yml
PYTHONPATH=../../lib ../bin/plugin_formatter.py -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Evaluating module files...
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../bin/plugin_formatter.py", line 783, in <module>
    main()
  File "../bin/plugin_formatter.py", line 738, in main
    plugin_info, categories = get_plugin_info(options.module_dir, limit_to=options.limit_to, verbose=(options.verbosity > 0))
  File "../bin/plugin_formatter.py", line 294, in get_plugin_info
    doc, examples, returndocs, metadata = plugin_docs.get_docstring(module_path, fragment_loader, verbose=verbose)
  File "/root/ansible/lib/ansible/utils/plugin_docs.py", line 105, in get_docstring
    data = read_docstring(filename, verbose=verbose, ignore_errors=ignore_errors)
  File "/root/ansible/lib/ansible/parsing/plugin_docs.py", line 59, in read_docstring
    data[varkey] = AnsibleLoader(child.value.s, file_name=filename).get_single_data()
  File "/usr/local/lib/python3.6/dist-packages/yaml/constructor.py", line 41, in get_single_data
    node = self.get_single_node()
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 36, in get_single_node
    document = self.compose_document()
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 55, in compose_document
    node = self.compose_node(None, None)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 82, in compose_node
    node = self.compose_sequence_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 110, in compose_sequence_node
    while not self.check_event(SequenceEndEvent):
  File "/usr/local/lib/python3.6/dist-packages/yaml/parser.py", line 98, in check_event
    self.current_event = self.state()
  File "/usr/local/lib/python3.6/dist-packages/yaml/parser.py", line 382, in parse_block_sequence_entry
    if self.check_token(BlockEntryToken):
  File "/usr/local/lib/python3.6/dist-packages/yaml/scanner.py", line 115, in check_token
    while self.need_more_tokens():
  File "/usr/local/lib/python3.6/dist-packages/yaml/scanner.py", line 152, in need_more_tokens
    self.stale_possible_simple_keys()
  File "/usr/local/lib/python3.6/dist-packages/yaml/scanner.py", line 292, in stale_possible_simple_keys
    "could not find expected ':'", self.get_mark())
yaml.scanner.ScannerError: while scanning a simple key
  in "<unicode string>", line 32, column 5:
        password
        ^
could not find expected ':'
  in "<unicode string>", line 33, column 18:
          description:
                     ^
make: *** [modules] Error 1

The test ansible-test sanity --test integration-aliases [explain] failed with 1 error:

test/integration/targets/dms_endpoint/aliases:0:0: missing alias `shippable/aws/group[1-2]` or `unsupported`

The test ansible-test sanity --test validate-modules [explain] failed with 12 errors:

lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: E312 No RETURN provided
lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: E324 Argument 'sslmode' in argument_spec defines default as ('none') but documentation defines default as (None)
lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: E324 Argument 'state' in argument_spec defines default as ('present') but documentation defines default as (None)
lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: E324 Argument 'validate_certs' in argument_spec defines default as (True) but documentation defines default as (False)
lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: E326 Argument 'endpointtype' in argument_spec defines choices as (['source', 'target']) but documentation defines choices as ([])
lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: E326 Argument 'enginename' in argument_spec defines choices as (['mysql', 'oracle', 'postgres', 'mariadb', 'aurora', 'redshift', 's3', 'db2', 'azuredb', 'sybase', 'dynamodb', 'mongodb', 'sqlserver']) but documentation defines choices as ([])
lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: E326 Argument 'sslmode' in argument_spec defines choices as (['none', 'require', 'verify-ca', 'verify-full']) but documentation defines choices as ([])
lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: E326 Argument 'state' in argument_spec defines choices as (['present', 'absent']) but documentation defines choices as ([])
lib/ansible/modules/cloud/amazon/dms_endpoint.py:17:0: E106 Import found before documentation variables. All imports must appear below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.
lib/ansible/modules/cloud/amazon/dms_endpoint.py:17:0: E107 Imports should be directly below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.
lib/ansible/modules/cloud/amazon/dms_endpoint.py:60:18: E302 DOCUMENTATION is not valid YAML
lib/ansible/modules/cloud/amazon/dms_endpoint.py:142:1: E311 EXAMPLES is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 2 errors:

lib/ansible/modules/cloud/amazon/dms_endpoint.py:60:18: error DOCUMENTATION: syntax error: could not find expected ':'
lib/ansible/modules/cloud/amazon/dms_endpoint.py:142:1: error EXAMPLES: syntax error: expected '<document start>', but found '<block sequence start>'

click here for bot help

ruimoreira added some commits Apr 1, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2019

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python3.6 test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
PYTHONPATH=../../lib ../bin/dump_config.py --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ -d ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../bin/generate_man.py --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../bin/dump_keywords.py --template-dir=../templates --output-dir=rst/reference_appendices/ -d ./keyword_desc.yml
PYTHONPATH=../../lib ../bin/plugin_formatter.py -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Evaluating module files...
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../bin/plugin_formatter.py", line 783, in <module>
    main()
  File "../bin/plugin_formatter.py", line 738, in main
    plugin_info, categories = get_plugin_info(options.module_dir, limit_to=options.limit_to, verbose=(options.verbosity > 0))
  File "../bin/plugin_formatter.py", line 294, in get_plugin_info
    doc, examples, returndocs, metadata = plugin_docs.get_docstring(module_path, fragment_loader, verbose=verbose)
  File "/root/ansible/lib/ansible/utils/plugin_docs.py", line 105, in get_docstring
    data = read_docstring(filename, verbose=verbose, ignore_errors=ignore_errors)
  File "/root/ansible/lib/ansible/parsing/plugin_docs.py", line 59, in read_docstring
    data[varkey] = AnsibleLoader(child.value.s, file_name=filename).get_single_data()
  File "/usr/local/lib/python3.6/dist-packages/yaml/constructor.py", line 41, in get_single_data
    node = self.get_single_node()
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 36, in get_single_node
    document = self.compose_document()
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 55, in compose_document
    node = self.compose_node(None, None)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 82, in compose_node
    node = self.compose_sequence_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 110, in compose_sequence_node
    while not self.check_event(SequenceEndEvent):
  File "/usr/local/lib/python3.6/dist-packages/yaml/parser.py", line 98, in check_event
    self.current_event = self.state()
  File "/usr/local/lib/python3.6/dist-packages/yaml/parser.py", line 382, in parse_block_sequence_entry
    if self.check_token(BlockEntryToken):
  File "/usr/local/lib/python3.6/dist-packages/yaml/scanner.py", line 116, in check_token
    self.fetch_more_tokens()
  File "/usr/local/lib/python3.6/dist-packages/yaml/scanner.py", line 223, in fetch_more_tokens
    return self.fetch_value()
  File "/usr/local/lib/python3.6/dist-packages/yaml/scanner.py", line 579, in fetch_value
    self.get_mark())
yaml.scanner.ScannerError: mapping values are not allowed here
  in "<unicode string>", line 37, column 15:
              Note: this attribute can only be wri ... 
                  ^
make: *** [modules] Error 1

The test ansible-test sanity --test integration-aliases [explain] failed with 1 error:

test/integration/targets/dms_endpoint/aliases:0:0: missing alias `shippable/aws/group[1-2]` or `unsupported`

The test ansible-test sanity --test validate-modules [explain] failed with 10 errors:

lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: E312 No RETURN provided
lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: E324 Argument 'sslmode' in argument_spec defines default as ('none') but documentation defines default as (None)
lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: E324 Argument 'state' in argument_spec defines default as ('present') but documentation defines default as (None)
lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: E324 Argument 'validate_certs' in argument_spec defines default as (True) but documentation defines default as (False)
lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: E326 Argument 'endpointtype' in argument_spec defines choices as (['source', 'target']) but documentation defines choices as ([])
lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: E326 Argument 'enginename' in argument_spec defines choices as (['mysql', 'oracle', 'postgres', 'mariadb', 'aurora', 'redshift', 's3', 'db2', 'azuredb', 'sybase', 'dynamodb', 'mongodb', 'sqlserver']) but documentation defines choices as ([])
lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: E326 Argument 'sslmode' in argument_spec defines choices as (['none', 'require', 'verify-ca', 'verify-full']) but documentation defines choices as ([])
lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: E326 Argument 'state' in argument_spec defines choices as (['present', 'absent']) but documentation defines choices as ([])
lib/ansible/modules/cloud/amazon/dms_endpoint.py:59:15: E302 DOCUMENTATION is not valid YAML
lib/ansible/modules/cloud/amazon/dms_endpoint.py:139:1: E311 EXAMPLES is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 2 errors:

lib/ansible/modules/cloud/amazon/dms_endpoint.py:59:15: error DOCUMENTATION: syntax error: mapping values are not allowed here
lib/ansible/modules/cloud/amazon/dms_endpoint.py:139:1: error EXAMPLES: syntax error: expected '<document start>', but found '<block sequence start>'

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2019

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python3.6 test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
PYTHONPATH=../../lib ../bin/dump_config.py --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ -d ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../bin/generate_man.py --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../bin/dump_keywords.py --template-dir=../templates --output-dir=rst/reference_appendices/ -d ./keyword_desc.yml
PYTHONPATH=../../lib ../bin/plugin_formatter.py -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Evaluating module files...
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../bin/plugin_formatter.py", line 783, in <module>
    main()
  File "../bin/plugin_formatter.py", line 738, in main
    plugin_info, categories = get_plugin_info(options.module_dir, limit_to=options.limit_to, verbose=(options.verbosity > 0))
  File "../bin/plugin_formatter.py", line 294, in get_plugin_info
    doc, examples, returndocs, metadata = plugin_docs.get_docstring(module_path, fragment_loader, verbose=verbose)
  File "/root/ansible/lib/ansible/utils/plugin_docs.py", line 105, in get_docstring
    data = read_docstring(filename, verbose=verbose, ignore_errors=ignore_errors)
  File "/root/ansible/lib/ansible/parsing/plugin_docs.py", line 59, in read_docstring
    data[varkey] = AnsibleLoader(child.value.s, file_name=filename).get_single_data()
  File "/usr/local/lib/python3.6/dist-packages/yaml/constructor.py", line 41, in get_single_data
    node = self.get_single_node()
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 36, in get_single_node
    document = self.compose_document()
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 55, in compose_document
    node = self.compose_node(None, None)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 82, in compose_node
    node = self.compose_sequence_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 110, in compose_sequence_node
    while not self.check_event(SequenceEndEvent):
  File "/usr/local/lib/python3.6/dist-packages/yaml/parser.py", line 98, in check_event
    self.current_event = self.state()
  File "/usr/local/lib/python3.6/dist-packages/yaml/parser.py", line 382, in parse_block_sequence_entry
    if self.check_token(BlockEntryToken):
  File "/usr/local/lib/python3.6/dist-packages/yaml/scanner.py", line 116, in check_token
    self.fetch_more_tokens()
  File "/usr/local/lib/python3.6/dist-packages/yaml/scanner.py", line 223, in fetch_more_tokens
    return self.fetch_value()
  File "/usr/local/lib/python3.6/dist-packages/yaml/scanner.py", line 579, in fetch_value
    self.get_mark())
yaml.scanner.ScannerError: mapping values are not allowed here
  in "<unicode string>", line 37, column 15:
              Note: this attribute can only be written
                  ^
make: *** [modules] Error 1

The test ansible-test sanity --test integration-aliases [explain] failed with 1 error:

test/integration/targets/dms_endpoint/aliases:0:0: missing alias `shippable/aws/group[1-2]` or `unsupported`

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dms_endpoint.py:149:1: W293 blank line contains whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 9 errors:

lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: E312 No RETURN provided
lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: E324 Argument 'sslmode' in argument_spec defines default as ('none') but documentation defines default as (None)
lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: E324 Argument 'state' in argument_spec defines default as ('present') but documentation defines default as (None)
lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: E324 Argument 'validate_certs' in argument_spec defines default as (True) but documentation defines default as (False)
lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: E326 Argument 'endpointtype' in argument_spec defines choices as (['source', 'target']) but documentation defines choices as ([])
lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: E326 Argument 'enginename' in argument_spec defines choices as (['mysql', 'oracle', 'postgres', 'mariadb', 'aurora', 'redshift', 's3', 'db2', 'azuredb', 'sybase', 'dynamodb', 'mongodb', 'sqlserver']) but documentation defines choices as ([])
lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: E326 Argument 'sslmode' in argument_spec defines choices as (['none', 'require', 'verify-ca', 'verify-full']) but documentation defines choices as ([])
lib/ansible/modules/cloud/amazon/dms_endpoint.py:0:0: E326 Argument 'state' in argument_spec defines choices as (['present', 'absent']) but documentation defines choices as ([])
lib/ansible/modules/cloud/amazon/dms_endpoint.py:58:15: E302 DOCUMENTATION is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dms_endpoint.py:58:15: error DOCUMENTATION: syntax error: mapping values are not allowed here

click here for bot help

ruimoreira added some commits Apr 15, 2019

@willthames

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

@ruimoreira for now you can use unsupported rather than aws/groupX in the aliases - that will make the automated tests pass until the permissions are added - we can run the tests manually in the interim.

@mattclay / @s-hertel can you let @ruimoreira know if there's anything to be done to get automated tests working?

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

@BobBoldin @Constantin007 @Constantin07 @Deepakkothandan @Etherdaemon @Java1Guy @Madhura-CSI @MichaelBaydoun @Sodki @Zeekin @adq @akazakov @alachaum @amir343 @anryko @bekelchik @brandond @captainkerk @chenl87 @defunctio @dennisconrad @dkhenry @fiunchinho @fivethreeo @flowerysong @garethr @gobins @gunzy83 @gurumaia @hsingh @hyperized @iiibrad @infectsoldier @j-carl @jarv @Java1Guy @jimbydamonk @jmenga @joelthompson @jonhadfield @jonmer85 @joshsouza @jsdalton @jsmartin @kaczynskid @leedm777 @linuxdynasty @loia @lwade @michaeljs1990 @minichate @mjschultz @mmochan @nand0p @naslanidis @nathanwebsterdotme @nerzhul @nickball @orthanc @ozbillwang @piontas @pjodouin @prasadkatti @psykotox @ptux @pwnall @raags @rafaeldriutti @rickmendes @roadmapper @rrey @ryansb @ryansydnor @scicoin-project @scottanderson42 @sdubrul @shepdelacreme @silviud @slapula @steynovich @tastychutney @tgerla @timmahoney @tomislacker @tsiganenok @viper233 @whiter @willricardo @wilvk @wimnat @yaakov-github @zacblazic @zbal @zimbatm

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

aws_secret_key: "{{ aws_secret_key }}"
#security_token: "{{ security_token }}"
region: "{{ aws_region }}"
no_log: no

This comment has been minimized.

Copy link
@BobBoldin

BobBoldin Apr 15, 2019

Contributor

please set no_log: yes

This comment has been minimized.

Copy link
@ruimoreira

ruimoreira Apr 15, 2019

Author Contributor

Done ! Thank you

@BobBoldin

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

Ran tests locally, all passed though expect on parallel testing will cross-detect resources. Will add comment to test file with possible update. Likely should have an always section to block in case a test fails it will still delete the endpoint.

ansible 2.9.0.dev0
python version = 2.7.5
Red Hat Enterprise Linux Server release 7.5 (Maipo)

For CI permissions, testing output:
AWS ACTIONS: ['dms:CreateEndpoint', 'dms:DeleteEndpoint', 'dms:DescribeEndpoints', 'dms:ModifyEndpoint']

#security_token: "{{ security_token }}"
region: "{{ aws_region }}"
no_log: yes

This comment has been minimized.

Copy link
@BobBoldin

BobBoldin Apr 15, 2019

Contributor

May want to create a fact so the endpointidentifier will always be unique.

  • name: generate unique value for testing
    set_fact:
    dms_identifier: "{{ resource_prefix }}-dms"
- name: create endpoints
dms_endpoint:
state: present
endpointidentifier: 'testsource'

This comment has been minimized.

Copy link
@BobBoldin

BobBoldin Apr 15, 2019

Contributor

change reference to fact if decide to use it.

Suggested change
endpointidentifier: 'testsource'
endpointidentifier: "{{ dms_identifier }}"
- name: create endpoints no change
dms_endpoint:
state: present
endpointidentifier: 'testsource'

This comment has been minimized.

Copy link
@BobBoldin

BobBoldin Apr 15, 2019

Contributor

Same and all other occurrences update to use fact identifier

- assert:
that:
- result is not changed
- result is not failed

This comment has been minimized.

Copy link
@BobBoldin

BobBoldin Apr 15, 2019

Contributor
Suggested change
- result is not failed
- result is not failed
always:
###### TEARDOWN STARTS HERE ######
- name: delete endpoints
dms_endpoint:
state: absent
endpointidentifier: 'testsource'
endpointtype: source
enginename: aurora
username: testing
password: testint1234
servername: testing.moreira.dom
port: 3306
databasename: 'testdb'
sslmode: none
wait: True
timeout: 60
retries: 10
<<: *aws_connection_info
@willthames

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

Thanks @BobBoldin for the additional suggestions, those were pretty much my remaining concerns too.

Once those are addressed this should be good to merge

@ruimoreira

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

Will commit this asap.
Thank you both for your help

@mattclay

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

I've added this PR to the backlog of permissions updates for our CI system to support automated testing. Unfortunately I don't know when we'll be able to get to this. Marking the test unsupported in the meantime will allow merging -- at the risk of having future modifications to the module and/or tests potentially result in undetected failures.

@ruimoreira

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

@willthames @BobBoldin I have done the suggested changes, please review.
I will now start working on another PR for another module still on the DMS side of AWS

@ruimoreira

This comment has been minimized.

Copy link
Contributor Author

commented Apr 17, 2019

Can someone have a last look at this ?
Should be ready for merge according to feedback provided

@willthames willthames merged commit 10b02e1 into ansible:devel Apr 18, 2019

1 check passed

Shippable Run 119493 status is SUCCESS.
Details
@willthames

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

Merged, thanks @ruimoreira

@sivel sivel removed the needs_triage label Apr 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.