Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add azure monitor log profile module #54702

Open
wants to merge 5 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@yungezz
Copy link
Contributor

commented Apr 2, 2019

SUMMARY

add new module azure_rm_monitorlogprofile. mark as WIP to avoid be merged into 2.8.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2019

@yungezz, just so you are aware we have a dedicated Working Group for azure.
You can find other people interested in this in #ansible-azure on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_monitorlogprofile.py:324:34: E131 continuation line unaligned for hanging indent

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_monitorlogprofile.py:0:0: E307 version_added should be '2.8'. Currently '2.9'

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_monitorlogprofile.py:324:34: E131 continuation line unaligned for hanging indent

click here for bot help

@yungezz

This comment has been minimized.

Copy link
Contributor Author

commented Apr 12, 2019

HI @mattclay seems test account doesn't have permission to create log profile, pls see below error:

"Error creating/updating log profile: Azure Error: AuthorizationFailed\nMessage: The client 'xxxxxxxxxxxxxxxxxxx' with object id 'xxxxxxxxxxx' does not have authorization to perform action 'microsoft.insights/logprofiles/write' over scope '/subscriptions/xxxxxxxxxxxxxxxxxxxx'."

https://app.shippable.com/github/ansible/ansible/runs/117172/114/tests

Could you pls grant necessary permission? Thanks.

@mattclay

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

@yungezz I don't think we'll be able to test this with our current CI system. This feature appears to operate at the subscription level, rather than the resource group or resource level. We don't have a safe way to expose privileges for managing the subscription currently.

You can still create tests and run them locally, but you'll need to mark the test unsupported in the aliases file to have it skipped in CI.

@ansibot ansibot removed the needs_triage label Apr 12, 2019

@yungezz

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

got it. thanks Matt @mattclay .

@ansibot ansibot removed the stale_ci label Apr 16, 2019

@yungezz yungezz changed the title [WIP] add azure monitor log profile module add azure monitor log profile module Apr 16, 2019

@ansibot ansibot added community_review and removed WIP labels Apr 16, 2019

@yungezz

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

ready_for_review

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

@Madhura-CSI @brusMX @caohai @cperrin88 @devigned @gustavomcarmo @haroldwongms @iphilpot @julienstroheker @lmazuel @obsoleted @sozercan @techknowlogick @trstringer @tstringer @xscript @yaweiw @yuwzho

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@Fred-sun

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

@yuwzho @zikalino review_need

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.