Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for querying IPMI power status #54771

Open
wants to merge 6 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@remixtj
Copy link
Contributor

remixtj commented Apr 3, 2019

SUMMARY

User may want to query for power status of an ipmi device
instead of changing it. With ipmi_facts, current state of the
ipmi status is returned and user may, as example, loop until a
desired power status is reached.
We developed this option because we have some tasks to
perform on storage side on some machines that boot from SAN.
These operations require to have machines powered off.

ISSUE TYPE
  • New Module pull request
COMPONENT NAME

ipmi_facts

ADDITIONAL INFORMATION

Check docs included in the module for a sample of usage of the new parameter

Add support for querying IPMI power status
User may want to query for power status of an ipmi device
instead of changing it. With 'query' state, current power
status is returned and user may, as example, loop until a
desired power status is reached.
We developed this option because we have some tasks to
perform on storage side on some machines that boot from SAN.
These operations require to have machines powered off.
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Apr 3, 2019

@jamescassell
Copy link
Contributor

jamescassell left a comment

'query' is not a 'state' -- this should be a separate module, likely _info or_facts

remixtj added some commits Apr 4, 2019

Added ipmi_facts module
Instead of using query option, as stated by previous
comments, i added a module for checking for ipmi status
@remixtj

This comment has been minimized.

Copy link
Contributor Author

remixtj commented Apr 4, 2019

@jamescassell Thank for the commends i'm creating a fact module instead

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Apr 4, 2019

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/modules/remote_management/ipmi/ipmi_facts.py:126:49: trailing-whitespace Trailing whitespace
lib/ansible/modules/remote_management/ipmi/ipmi_facts.py:136:41: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/remote_management/ipmi/ipmi_facts.py:126:50: W291 trailing whitespace
lib/ansible/modules/remote_management/ipmi/ipmi_facts.py:136:42: W291 trailing whitespace

click here for bot help

@ansibot ansibot added the ci_verified label Apr 4, 2019

@ansibot ansibot removed the ci_verified label Apr 4, 2019

@remixtj

This comment has been minimized.

Copy link
Contributor Author

remixtj commented Apr 9, 2019

ready_for_review

@remixtj

This comment has been minimized.

Copy link
Contributor Author

remixtj commented Apr 9, 2019

bot_status

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Apr 9, 2019

@bgaifullin @cloudnull

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Apr 9, 2019

Components

lib/ansible/modules/remote_management/ipmi/ipmi_facts.py
support: community
maintainers: cloudnull

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 0
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainer or core team member): []
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.