Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fortinet FortiManager fmgr_fwpol_package UPDATE #54805

Closed
wants to merge 9 commits into from

Conversation

Projects
None yet
4 participants
@ftntcorecse
Copy link
Contributor

ftntcorecse commented Apr 3, 2019

SUMMARY
  • Couldn't append to installation target list, only send a complete list. We've added modes for adding and deleting just targets for policy packages.
  • Install mode has been added. Scope_members is no longer taken into account when mode = install. Only the existing installation targets on the package will be used. Update installation targets before.
  • Nested folders and packages now work properly. Before they were not.
  • When using modes "add" or "set" with object_type = "pkg" the installation targets are STILL OVERWRITTEN with what was supplied under scope_members and scope_groups. Use the add_targets or delete_targets mode first.
  • When using "add_targets" or "delete_targets" for changing installation targets, only scope_members or scope_groups is considered for changes to the package. To edit the package settings themselves, use "set".
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

modules/network/fortimanager/fmgr_fwpol_package.py

ADDITIONAL INFORMATION

lweighall added some commits Feb 21, 2019

Added Append_scope_members list. Defaults to enable, but if you disab…
…le it, it will still allow the overwriting of members.

Also, moved the creation of scope_members JSON structure out of each method, into a pre-method-exec operation so it's just passed through to methods to be sent.
Fixed issues:
1) Couldn't append to installation target list, only send a complete list. We've added modes for adding and deleting just targets for policy packages.

2) Install mode has been added. Scope_members is no longer taken into account when mode = install. Only the existing installation targets on the package will be used. Update installation targets before installing.

3) Nested folders and packages now work properly. Before they were not.

4) When using modes "add" or "set" with object_type = "pkg" the installation targets are STILL OVERWRITTEN with what was supplied under scope_members and scope_groups. Use the add_targets or delete_targets mode with another task to append or delete targets.

5) When using "add_targets" or "delete_targets" for changing installation targets, only scope_members or scope_groups is considered for changes to the package. To edit the package settings themselves, use "set".
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Apr 3, 2019

@ftntcorecse this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Apr 3, 2019

@ftntcorecse, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot removed the needs_revision label Apr 3, 2019

@ansibot ansibot added the stale_ci label Apr 11, 2019

@ftntcorecse

This comment has been minimized.

Copy link
Contributor Author

ftntcorecse commented Apr 17, 2019

Closing, repo no longer exists. Re-opening later.

@sivel sivel removed the needs_triage label Apr 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.