Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved netapp_e_facts module. #54816

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
2 participants
@ndswartz
Copy link
Contributor

ndswartz commented Apr 3, 2019

SUMMARY

Added the following facts:

  • storage system segment size
  • cache block size capabilities
  • workload tags
  • storage array hosts
  • host groups
  • list of mapped volumes for each initiator
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

netapp_e_facts

ADDITIONAL INFORMATION
ansible 2.8.0.dev0
  config file = None
  configured module search path = [u'/home/swartzn/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/swartzn/ansible-dev/lib/ansible
  executable location = /home/swartzn/ansible-dev/bin/ansible
  python version = 2.7.15rc1 (default, Nov 12 2018, 14:31:15) [GCC 7.3.0]
@ansibot

This comment was marked as resolved.

Copy link
Contributor

ansibot commented Apr 3, 2019

The test ansible-test sanity --test boilerplate [explain] failed with 2 errors:

lib/ansible/modules/storage/netapp/netapp_e_facts.py:0:0: missing: __metaclass__ = type
lib/ansible/modules/storage/netapp/netapp_e_facts.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test validate-modules [explain] failed with 6 errors:

lib/ansible/modules/storage/netapp/netapp_e_facts.py:0:0: E305 DOCUMENTATION.author: required key not provided @ data['author']. Got None
lib/ansible/modules/storage/netapp/netapp_e_facts.py:0:0: E305 DOCUMENTATION.authors: extra keys not allowed @ data['authors']. Got ['Kevin Hulquest (@hulquest)', 'Nathan Swartz (@ndswartz)']
lib/ansible/modules/storage/netapp/netapp_e_facts.py:0:0: E316 ANSIBLE_METADATA.metadata_version: required key not provided @ data['metadata_version']. Got None
lib/ansible/modules/storage/netapp/netapp_e_facts.py:0:0: E316 ANSIBLE_METADATA.version: extra keys not allowed @ data['version']. Got '1.0'
lib/ansible/modules/storage/netapp/netapp_e_facts.py:66:62: E313 RETURN is not valid YAML
lib/ansible/modules/storage/netapp/netapp_e_facts.py:626:0: E403 Type comparison using type() found. Use isinstance() instead

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/netapp_e_facts.py:66:62: error RETURN: syntax error: expected <block end>, but found '<scalar>'

click here for bot help

@ansibot

This comment has been minimized.

@ansibot

This comment was marked as resolved.

Copy link
Contributor

ansibot commented Apr 5, 2019

The test ansible-test sanity --test boilerplate [explain] failed with 2 errors:

lib/ansible/modules/storage/netapp/netapp_e_facts.py:0:0: missing: __metaclass__ = type
lib/ansible/modules/storage/netapp/netapp_e_facts.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/storage/netapp/netapp_e_facts.py:0:0: E316 ANSIBLE_METADATA.metadata_version: not a valid value for dictionary value @ data['metadata_version']. Got '1.0'
lib/ansible/modules/storage/netapp/netapp_e_facts.py:106:28: E313 RETURN is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/netapp_e_facts.py:106:28: error RETURN: syntax error: could not find expected ':'

click here for bot help

@ansibot ansibot added the ci_verified label Apr 5, 2019

@ndswartz ndswartz force-pushed the ndswartz:facts_dev_upstream branch from 48a85b9 to 5ef4373 Apr 5, 2019

@ansibot ansibot removed the ci_verified label Apr 5, 2019

@ndswartz ndswartz force-pushed the ndswartz:facts_dev_upstream branch 2 times, most recently from d833d81 to 5aa0016 Apr 5, 2019

Swartz, Nathan Swartz, Nathan
Improved netapp_e_facts module.
Added the following facts:
  - storage system segment size
  - cache block size capabilities
  - workload tags
  - storage array hosts
  - host groups
  - list of mapped volumes for each initiator

@ndswartz ndswartz force-pushed the ndswartz:facts_dev_upstream branch from 5aa0016 to f2ee395 Apr 5, 2019

@ansibot ansibot added the stale_ci label Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.