Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for os_coe_cluster_template module (#54819) #54820

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
4 participants
@NewpTone
Copy link

commented Apr 3, 2019

  • Support 'overlay2' in docker_storage_driver

  • Fixed the data type in labels

  • Improve string process with parsing labels

SUMMARY

Fixes #54819

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

os_coe_cluster_template

ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_coe_cluster_template.py:0:0: E326 Argument 'docker_storage_driver' in argument_spec defines choices as (['devicemapper', 'overlay', 'overlay2']) but documentation defines choices as (['devicemapper', 'overlay'])

click here for bot help

@openstack-zuul

This comment has been minimized.

Copy link

commented Apr 4, 2019

Build succeeded (third-party-check pipeline).

Xingchao Yu
Bugfix for os_coe_cluster_template module (#54819)
* Support 'overlay2' in docker_storage_driver

* Fixed the data type in labels

* Improve string process with parsing labels

@NewpTone NewpTone force-pushed the NewpTone:fix_os_coe_cluster_template branch to 258b220 Apr 4, 2019

@mnaser

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

shipit

@ansibot ansibot removed the needs_triage label Apr 4, 2019

@openstack-zuul

This comment has been minimized.

Copy link

commented Apr 4, 2019

Build succeeded (third-party-check pipeline).

@openstacker

This comment has been minimized.

Copy link
Contributor

commented Apr 7, 2019

/lgtm

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 7, 2019

@ansibot ansibot added the stale_ci label Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.