Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Bug#54050 #54863

Merged
merged 4 commits into from Apr 24, 2019

Conversation

Projects
None yet
4 participants
@twbowman
Copy link
Contributor

commented Apr 4, 2019

SUMMARY

Fixes #54050.

This does a silent ignore on interfaces that don't exist.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

eos_l2_interface

ADDITIONAL INFORMATION

Playbook for testing:

- hosts: tb7280-1 
  gather_facts: false

  vars:
    l2_interfaces:
        - {name: Ethernet1/1, mode: trunk, state: present}
        - {name: Ethernet2/1, mode: trunk, state: present}

  tasks:
    - name: l2 interfaces
      eos_l2_interface:
         aggregate: "{{l2_interfaces}}"

Before Changes

PLAY [tb7280-1] *********************************************************************************************************************

TASK [l2 interfaces] ****************************************************************************************************************
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: IndexError: list index out of range
fatal: [tb7280-1]: FAILED! => {"changed": false, "module_stderr": "Traceback (most recent call last):\n  File \"/home/aws_svcs/.ansible/tmp/ansible-local-879416tgl33/ansible-tmp-1554388404.83-267013644925932/AnsiballZ_eos_l2_interface.py\", line 113, in <module>\n    _ansiballz_main()\n  File \"/home/aws_svcs/.ansible/tmp/ansible-local-879416tgl33/ansible-tmp-1554388404.83-267013644925932/AnsiballZ_eos_l2_interface.py\", line 105, in _ansiballz_main\n    invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)\n  File \"/home/aws_svcs/.ansible/tmp/ansible-local-879416tgl33/ansible-tmp-1554388404.83-267013644925932/AnsiballZ_eos_l2_interface.py\", line 48, in invoke_module\n    imp.load_module('__main__', mod, module, MOD_DESC)\n  File \"/tmp/ansible_eos_l2_interface_payload_t2G3ET/__main__.py\", line 314, in <module>\n  File \"/tmp/ansible_eos_l2_interface_payload_t2G3ET/__main__.py\", line 298, in main\n  File \"/tmp/ansible_eos_l2_interface_payload_t2G3ET/__main__.py\", line 212, in map_config_to_obj\nIndexError: list index out of range\n", "module_stdout": "", "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error", "rc": 1}
	to retry, use: --limit @/home/aws_svcs/ansible-datacenter/eos_l2_test.retry

PLAY RECAP **************************************************************************************************************************
tb7280-1                   : ok=0    changed=0    unreachable=0    failed=1

After Changes

PLAY [tb7280-1] ******************************************************************************************************************************************************************

TASK [l2 interfaces] *************************************************************************************************************************************************************
ok: [tb7280-1]

PLAY RECAP ***********************************************************************************************************************************************************************
tb7280-1                   : ok=1    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0 

Todd Bowman added some commits Mar 26, 2019

Todd Bowman

@twbowman twbowman changed the title Bug#54050 Fix for Bug#54050 Apr 4, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

The test ansible-test sanity --test pylint [explain] failed with 3 errors:

lib/ansible/modules/network/eos/eos_l2_interface.py:217:14: bad-whitespace No space allowed before bracket         print ("command_result = %s" % (len(command_result)))               ^
lib/ansible/modules/network/eos/eos_l2_interface.py:218:35: trailing-whitespace Trailing whitespace
lib/ansible/modules/network/eos/eos_l2_interface.py:220:0: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

lib/ansible/modules/network/eos/eos_l2_interface.py:217:14: E211 whitespace before '('
lib/ansible/modules/network/eos/eos_l2_interface.py:218:36: W291 trailing whitespace
lib/ansible/modules/network/eos/eos_l2_interface.py:220:1: W293 blank line contains whitespace

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

@twbowman, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

Todd Bowman
Todd Bowman

@ansibot ansibot removed the stale_ci label Apr 24, 2019

@ansibot ansibot removed the support:core label Apr 24, 2019

@Qalthos Qalthos merged commit d0ae686 into ansible:devel Apr 24, 2019

1 check passed

Shippable Run 120575 status is SUCCESS.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.