Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip]test: vcenter provider static config #54864

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
4 participants
@goneri
Copy link
Contributor

commented Apr 4, 2019

SUMMARY

The vcenter provider can now use a static configuration file, this give
a way to run the test-suite on a regular environment.
The configuration file is located here:

test/integration/cloud-config-vcenter.ini

Note: This commit also generalizes the use of vcenter_hostname instead
of vcenter_host. This to be consistent with what is done in the
documentation.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

vmware

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

test: vcenter provider static config
The vcenter provider can now use a static configuration file, this give
a way to run the test-suite on a regular environment.
The configuration file is located here:

  test/integration/cloud-config-vcenter.ini

Note: This commit also generalizes the use of `vcenter_hostname` instead
of `vcenter_host`. This to be consistent with what is done in the
documentation.

@goneri goneri force-pushed the goneri:vmware_static_vcenter_provider branch to b0e5d53 Apr 4, 2019

@jillr

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

Testing this with a static config fails for me; var vcsim ends up undefined. If I hack around that and add like vcsim=self._get_cloud_config('vcenter_hostname') to ansible_vars, ansible-test hangs on any 'Wait for Flask controller to come up online' task as vcenter doesn't use port 5000 for anything and that's hard-coded in our tests. We need to do a bunch of refactoring before we can use the existing targets with this.
Would it better to:

  1. Do that refactoring first
  2. Add a second test provider for static/baremetal vcenters that we can write some quick tests on, then merge them as we refactor targets to be more flexible?
@goneri

This comment has been minimized.

Copy link
Contributor Author

commented Apr 4, 2019

Yes, the test-suite is broken. I'm doing a large refactoring of the test-suite to handle the case we run with or without vcsim ( #54882 ). I'm fine if we merge everything at the same time.

@bcoca bcoca added cloud vmware and removed needs_triage labels Apr 9, 2019

@goneri goneri changed the title test: vcenter provider static config [wip]test: vcenter provider static config Apr 12, 2019

@ansibot ansibot added the stale_ci label Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.