Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMware: vmware_datastore_facts: don't nodify dict in iter (#54869) #54870

Merged

Conversation

Projects
None yet
3 participants
@goneri
Copy link
Contributor

commented Apr 4, 2019

SUMMARY

With Python3, we cannot iterate on a dict and modify it at the same time.

Fixes ##54869

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vmware_datastore_facts

ADDITIONAL INFORMATION

vmware_datastore_facts: don't nodify dict in iter (#54869)
With Python3, we cannot iterate on a dict and modify it at the same time.

Fixes ##54869
@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

@goneri, just so you are aware we have a dedicated Working Group for vmware.
You can find other people interested in this in #ansible-vmware on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@Akasurde Akasurde changed the title vmware_datastore_facts: don't nodify dict in iter (#54869) VMware: vmware_datastore_facts: don't nodify dict in iter (#54869) Apr 5, 2019

@Akasurde Akasurde self-assigned this Apr 5, 2019

@Akasurde Akasurde removed the needs_triage label Apr 5, 2019

@ansibot ansibot added the stale_ci label Apr 13, 2019

@goneri goneri requested a review from Akasurde Apr 15, 2019

@Akasurde

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

rebuild_merge

@ansibot ansibot merged commit 339a0f4 into ansible:devel Apr 17, 2019

1 check passed

Shippable Run 119571 status is SUCCESS.
Details

ruimoreira added a commit to ruimoreira/ansible that referenced this pull request Apr 22, 2019

vmware_datastore_facts: don't nodify dict in iter (ansible#54869) (an…
…sible#54870)

With Python3, we cannot iterate on a dict and modify it at the same time.

Fixes #ansible#54869
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.