Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added parsing of LLDP remote port description #54873

Merged
merged 2 commits into from Apr 24, 2019

Conversation

Projects
None yet
3 participants
@marouim
Copy link
Contributor

commented Apr 4, 2019

SUMMARY

Cisco IOS-XR show lldp neighbors command returns the port description from the remote device it is connected to. This information is not actually parsed by the iosxr_facts module. This patch add the parsing of the remote port description from LLDP output.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

/lib/modules/network/iosxr/iosxr_facts.py

ADDITIONAL INFORMATION

The command "show lldp neighbors detail" returns several useful informations that can be used from a script for inventory or other tasks.

This pull request is a proposal to make the remote port description available in the ansible_net_neighbors object.

RP/0/RP0/CPU0:tor-15.tenlab-cloud#show lldp neighbors detail

[ ... output ommited ... ]
------------------------------------------------
Local Interface: TenGigE0/0/0/47
Chassis id: XX
Port id: XX
Port Description: Interface  12 as sriov-1-1
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

@marouim, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/network/iosxr/iosxr_facts.py:359:0: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/network/iosxr/iosxr_facts.py:359:1: W293 blank line contains whitespace

click here for bot help

@justjais justjais self-requested a review Apr 10, 2019

Martin Ouimet

@justjais justjais merged commit 3337409 into ansible:devel Apr 24, 2019

1 check passed

Shippable Run 118849 status is SUCCESS.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.