Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 13 asterisk characters in password field without warning #54893

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
4 participants
@kucharskim
Copy link

commented Apr 5, 2019

SUMMARY

On OpenBSD, 13 asterisk characters as a password hash, marks the
account as disabled. Otherwise daily(8) script which executes
security(8) will email operator about not properly locked accounts.

Before the diff, we see following warning:

[WARNING]: The input password appears not to have been hashed. The 'password' argument must be encrypted for this module to work properly.

After the diff, warning is gone.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • modules/system/user.py
ADDITIONAL INFORMATION

I can provide more info, if needed.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 5, 2019

@kucharskim: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type

Please set the description of this pullrequest with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/PULL_REQUEST_TEMPLATE.md

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 5, 2019

@kucharskim

This comment has been minimized.

Copy link
Author

commented Apr 5, 2019

I tried to unit tests myself my diff, but so far didn't had luck to run tests, so my diff is tested live on OpenBSD systems, without execution of unit tests. Unit tests use a lot of hardcoded paths to python (which I needed to modify) and it seems framework is not compatible with non-wxallowed mount(8) points on OpenBSD.

@samdoran
Copy link
Member

left a comment

Change looks good. Thank you for adding tests. Please create a changelog fragment. See this fragment as an example.

@kucharskim kucharskim force-pushed the kucharskim:devel branch from 1e3401b to 467ce68 Apr 13, 2019

@kucharskim

This comment has been minimized.

Copy link
Author

commented Apr 13, 2019

@samdoran, please let me know does the changelog fragment looks good, or do I need to make some additional changes. Thanks.

Allow 13 asterisk characters in password field without warning
On OpenBSD, 13 asterisk characters as a password hash, marks the
account as disabled. Otherwise daily(8) script which executes
security(8) will email operator about not properly locked accounts.

Before the diff, we see following warning:

> [WARNING]: The input password appears not to have been hashed. The 'password' argument must be encrypted for this module to work properly.

After the diff, warning is gone.

@kucharskim kucharskim force-pushed the kucharskim:devel branch from 467ce68 to 302adea Apr 17, 2019

@ansibot ansibot added core_review and removed needs_revision labels Apr 17, 2019

@ansibot ansibot added the stale_ci label Apr 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.