Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add encoding and codepage params to win_command/win_shell (#54896) #54966

Open
wants to merge 7 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@h-hirokawa
Copy link
Contributor

commented Apr 8, 2019

SUMMARY

Add new encoding and codepage params to win_command/win_shell. Now you can set custom encoding to stdout/stderr.
Since the default encoding is still UTF-8, so the PR has no breaking changes.

Fixes #54896

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

win_command
win_shell
Ansible.Process.cs
Ansible.ModuleUtils.CommandUtil.psm1

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2019

@h-hirokawa this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot

This comment has been minimized.

@h-hirokawa h-hirokawa changed the title Add encoding and codepage params to win_command/win_shell (#54896) WIP: Add encoding and codepage params to win_command/win_shell (#54896) Apr 8, 2019

@ansibot ansibot added the WIP label Apr 8, 2019

@h-hirokawa h-hirokawa force-pushed the h-hirokawa:fix-54896 branch from c8d3c13 to 854ec1b Apr 8, 2019

@h-hirokawa h-hirokawa changed the title WIP: Add encoding and codepage params to win_command/win_shell (#54896) Add encoding and codepage params to win_command/win_shell (#54896) Apr 8, 2019

@ansibot ansibot removed the WIP label Apr 8, 2019

@h-hirokawa

This comment has been minimized.

Copy link
Contributor Author

commented Apr 8, 2019

@dagwieers @if-meaton @jborean93 @jhawkesworth @nitzmahone
The tests seems working properly, but shippable T=windows/2008/1 env failed because the 45-minute time limit has been exceeded. Is there a workaround for this?

@h-hirokawa h-hirokawa force-pushed the h-hirokawa:fix-54896 branch from 2c5149b to 7eec286 Apr 9, 2019

@bcoca bcoca removed the needs_triage label Apr 9, 2019

@jborean93

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

@h-hirokawa, thanks for working on this. Currently we are in a freeze period for core modules and we probably won't be able to have a look at this PR for a few weeks while we are squashing bugs for the 2.8 release. I'll definitely be having a look at this when we start to look at core features again I just wanted to make sure that you are aware it may take some time for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.