Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes PLAYBOOK_VARS_ROOT configuration option #55088

Conversation

Projects
None yet
3 participants
@wilmardo
Copy link
Contributor

wilmardo commented Apr 10, 2019

SUMMARY

Removes PLAYBOOK_VARS_ROOT configuration variable since it does nothing anymore

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vars\manager.py

ADDITIONAL INFORMATION

Since Ansible 2.3.x and 2.4.x are deprecated and the whole import/include playbook has been introduced this variable does nothing anymore and can only cause misunderstandings.

@bcoca
Copy link
Member

bcoca left a comment

this is incorrect and changes default behaviour to 'all' vs 'top'

@wilmardo wilmardo force-pushed the Intermax-Cloudsourcing:remove-playbook-vars-root branch 2 times, most recently from 14d88cd to b65170a Apr 11, 2019

@wilmardo

This comment has been minimized.

Copy link
Contributor Author

wilmardo commented Apr 11, 2019

@bcoca Fixed, got confused by the # should be default in the code. This should be it :)

ready_for_review

@bcoca

This comment has been minimized.

Copy link
Member

bcoca commented Apr 18, 2019

Hi!

Thanks very much for your submission to Ansible. It sincerely means a lot to us that you've taken time to contribute.

Unfortunately, we are going to decline this PR because of several reasons:

  • The setting does do something, and removing it gets rid of specific functionality, just not very interesting to most users, I'll try to update description to make a better explanation and add test that demonstrate the cases.

  • Even if it was not functional, we don't outright remove settings, they go through a deprecation period

However, we're absolutely always up for discussion.
Since this is a really busy project, we don't always see comments on closed tickets, but want to encourageopen dialog.

You can stop by the development list, and we'd be glad to talk about it - and we might even be persuaded otherwise!

In the future, sometimes starting a discussion on the development list prior to implenting a feature can make getting things included a little easier, but it's not always necessary.

Thank you once again for this and your interest in Ansible!

@bcoca bcoca closed this Apr 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.