Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Cpm serial port config #55102
referenced this pull request
Apr 10, 2019
@scarshouldofwon ,yes this module will work on the entire line of WTI OOB and PDU devices, including the DSM. You don’t need the latest firmware, but something within the past two years would be nice. Although updating to the latest firmware is always encouraged.
We're still working on fixing the test error. More tests are being triggered because of the change in
Could you go ahead and squash away the merge commit in the mean time? I don't care if you preserve my info in the history so long as you get the changes in.
If you want to kick tests, you can create an empty commit with just a message by running
Hi @samdoran No worries, I checked in new code (the checks failed but i am pretty sure all looks well) with the changes requested, except for converting the "cmd" parameter to bool, that caused an internal company uproar of what the "cmd" parameter does, so i let sleeping dogs lie.