Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding group parameter for win_firewall_rule #55109

Open
wants to merge 3 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@kvprasoon
Copy link

commented Apr 10, 2019

SUMMARY

Changes in this PR will add support to specify group parameter for the firewall rule.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_firewall_rule

ADDITIONAL INFORMATION

Current module doesn't support group parameter for win_firewall_rule module. This is a limitation for the user who needs to specify the group of the Firewall role to set/create.

Before:

  - name: test
    win_firewall_rule:
      name: 'Test Rule'
      program: 'c:\app\app1.exe'
      direction: In
      group:  TestGrp
      action: Allow
      state: Present

Result: Rule created without setting the group.

After:

- name: test
   win_firewall_rule:
     name: 'Test Rule'
     program: 'c:\app\app1.exe'
     direction: In
     group:  TestGrp
     action: Allow
     state: Present

Result: Rule created by setting the group.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2019

@kvprasoon

This comment has been minimized.

Copy link
Author

commented Apr 13, 2019

@jborean93 | @nitzmahone, When 2.8 release is planned ? I wish I could get this change in 2.8 as we will be upgrading to it once released in my org.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

@kvprasoon this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@kvprasoon kvprasoon force-pushed the kvprasoon:frw-grp branch from 30be7a7 to 847ab40 Apr 19, 2019

@kvprasoon

This comment has been minimized.

Copy link
Author

commented Apr 19, 2019

CI has failed expecting the version added as 2.9, but the previous value which is 2.8 was fine when the PR created. Updated the version to fix the CI.

@ansibot ansibot added core_review and removed needs_revision labels Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.