Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cosmetic] solaris wwn fix #55154

Merged
merged 2 commits into from Apr 18, 2019

Conversation

Projects
None yet
4 participants
@mator
Copy link
Contributor

commented Apr 11, 2019

SUMMARY

remove external grep call and simplify module.run_command() by removing use_unsafe_shell=True

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

facts module

mator added some commits Apr 11, 2019

Solaris WWN parsing cosmetic fix (commit 924f5b5)
* simplify module.run_command by removing use_unsafe_shell and remove calling of external grep
@mator

This comment has been minimized.

Copy link
Contributor Author

commented Apr 13, 2019

does it even need a changelog fragment? since nothing changes from a user perspective

@jillr jillr removed the needs_triage label Apr 18, 2019

@bcoca bcoca merged commit 701cf25 into ansible:devel Apr 18, 2019

1 check passed

Shippable Run 118845 status is SUCCESS.
Details

@mator mator deleted the mator:solaris_wwn_fix branch Apr 18, 2019

ruimoreira added a commit to ruimoreira/ansible that referenced this pull request Apr 22, 2019

[cosmetic] solaris wwn fix (ansible#55154)
* Solaris WWN parsing cosmetic fix (commit 924f5b5)

* simplify module.run_command by removing use_unsafe_shell and remove calling of external grep

* add changelog fragment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.