Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmware_host_config_manager: do not apply an empty list of change #55185

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
2 participants
@goneri
Copy link
Contributor

commented Apr 11, 2019

SUMMARY

In a multi-host context, changed_list will record all the changes
done on any host. So as soon as ONE host is changed, it will be True.

A host can potentially already have a parameter set, in this case
change_option_list will be empty.

This commit uses change_option_list instead of changed_list to
decided if a given host should be updated.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vmware_host_config_manager

vmware_host_config_manager: do not apply an empty list of change
In a multi-host context, `changed_list` will record all the changes
done on any host. So as soon as ONE host is changed, it will be `True`.

A host can potentially already have a parameter set, in this case
`change_option_list` will be empty.

This commit uses `change_option_list` instead of `changed_list` to
decided if a given host should be updated.

@goneri goneri requested a review from Akasurde Apr 11, 2019

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

@goneri, just so you are aware we have a dedicated Working Group for vmware.
You can find other people interested in this in #ansible-vmware on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.