Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
ec2_eip: move to boto3, add name and tags #55190
Idempotency should be improved with this PR if "name" and/or "public_ip" are used for identification, but I don't feel comfortable saying it is fully fixed without more test coverage.
This closes #50539
Sanity checks run locally against python 2.7, 3.5, and 3.7 using the following command and varying the python version:
Manually ran the integration test:
An example of the new output (captured from the integration test):
Tests 102, 103 failed with:
That looks to be a CI issue, similar to #54950? Not sure there is much I can do about this.
Test 1 failed with:
Since I just introduced the ec2_classic option, it seems like setting the version_added field to 2.8 is the correct thing to do. However, it does alias an older option (in_vpc) to preserve backwards compatibility. Does that mean I should set version_added to 1,4?
(edited: other errors fixed by removing manage_tags from ec2.py)
s-hertel left a comment •
The permissions failures in CI will need to be fixed by someone on the Ansible team. There is currently a queue.
Have you seen #50539? Please review it! It's more efficient to join efforts. It needs community reviews. That pull request was based off the initial work to port ec2_eip and picked up by someone new when the original contributor no longer had time for it. This is a really handy tool I use to find pull requests modifying the same file https://ansible.sivel.net/pr/byfile.html.