Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix netconf guess_network_os to use ssh_config if supplied. #55199

Open

Conversation

Projects
None yet
2 participants
@markafarrell
Copy link
Contributor

markafarrell commented Apr 12, 2019

SUMMARY

When attempting to set up a connection using netconf, if the ansible_network_os is set to either nothing or default, ansible will attempt to guess the network_os.

The guess consists of connecting to the target node and using the returned capabilities to try to determine which network_os should be use.

The initial connetion used to guess the network os ignores the ssh_config specified in ANSIBLE_NETCONF_SSH_CONFIG (or ansible.cfg)

As a result this initial connection will fail causing the play to fail.

This PR makes the following changes:

  1. Modifies the network_os_guessing to use a ssh_config file if specified.

  2. Triggers network_os guessing when the network_os is auto (instead of default). Allowing the user to specify that ansible use the default ncclient driver and not try to guess the network os.

Fixes #54859

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

netconf

ADDITIONAL INFORMATION
@ansibot

This comment has been minimized.

d384492 added some commits Apr 12, 2019

d384492 d384492
@markafarrell

This comment has been minimized.

Copy link
Contributor Author

markafarrell commented Apr 12, 2019

ready_for_review

@justjais justjais requested a review from ganeshrn Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.