Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: unit test for vmware_tools connection #55205

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
6 participants
@Akasurde
Copy link
Member

commented Apr 12, 2019

SUMMARY

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

test/units/plugins/connection/test_vmware_tools.py

@Akasurde

This comment has been minimized.

Copy link
Member Author

commented Apr 12, 2019

cc @jamescassell Could you please review this ? Thanks.

@jamescassell
Copy link
Contributor

left a comment

Overall, it looks good to me. Testing is not my strength, though I can mostly follow what it's testing.

@dericcrago does this test look good to you?

@dericcrago

This comment has been minimized.

Copy link
Contributor

commented Apr 13, 2019

@jamescassell - you're doing better than me. ;)

@Akasurde - could you provide a brief summary of your strategy and how this works? I'm not real clear on what is actually being tested with the use of the mocks.

@Akasurde

This comment has been minimized.

Copy link
Member Author

commented Apr 14, 2019

@Akasurde - could you provide a brief summary of your strategy and how this works? I'm not real clear on what is actually being tested with the use of the mocks.

@dericcrago Thanks for the vmware_tools connection plugin. This is just a unit test for checking basic functionality of vmware_tools connection. We are working (2.9) on CI environment based upon real vCenter environment which will test this connection plugin as a part of integration tests. let me know if you need any other information.

Thanks.

@ansibot ansibot removed the ci_verified label Apr 14, 2019

@Akasurde Akasurde force-pushed the Akasurde:vmware_tools_conn_test branch 2 times, most recently from b712786 to feaed3e Apr 14, 2019

test: unit test for vmware_tools connection
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

@Akasurde Akasurde force-pushed the Akasurde:vmware_tools_conn_test branch from feaed3e to db528a5 Apr 15, 2019

@jillr jillr removed the needs_triage label Apr 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.