Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow botocore configuration for aws modules #55217

Open
wants to merge 5 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@s-hertel
Copy link
Contributor

commented Apr 12, 2019

SUMMARY

WIP while still looking at a possible solution for boto modules.

This PR allows UserAgent to be set for boto modules and allows general configuration for boto3 modules. Many boto configurations can be set by a boto config file like connection timeout and proxy settings. UserAgent is not able to be configured in that way. In boto3 most of those options have been removed and are only modifiable via code. This addresses both problems.

Tested with CloudTrail.

Fix #55182

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

AWS modules

Example use:

    - name: create bucket
      aws_s3:
        aws_config:
          user_agent: "{{ custom_user_agent }}"
        bucket: "{{ bucket }}"
        region: us-east-1
        mode: create

@s-hertel s-hertel force-pushed the s-hertel:botocore_configuration branch from f06df04 to 3f3cfcc Apr 12, 2019

@s-hertel s-hertel changed the title [WIP] Allow botocore configuration to be configurable for boto3 modules Allow botocore configuration for aws modules Apr 12, 2019

@ansibot ansibot added core_review and removed needs_revision labels Apr 12, 2019

@jillr jillr removed the needs_triage label Apr 18, 2019

@s-hertel s-hertel requested review from goneri, jillr and Akasurde Apr 18, 2019

@jillr

jillr approved these changes Apr 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.