Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2_instance fix name idempotency (on 2nd call Name tag was being removed) #55224

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
4 participants
@jeking3
Copy link
Contributor

commented Apr 12, 2019

SUMMARY

If you run ec2_instance with name:, it gets a Name tag.
If you run the same playbook again, the Name tag disappears.
If you run it a third time, a new instance is created because it does not find the one where the name was removed.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_instance

ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

@jeking3, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@healem

healem approved these changes Apr 19, 2019

@Shaps

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

Looks ok to me, I would only add a comment in DOCUMENTATION pointing out the fact that if name is defined, the Name tag will be ignored

@ansibot ansibot added stale_ci and removed needs_triage labels Apr 24, 2019

@jeking3

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2019

@Shaps isn't the use of tag "Name" generically against best practices for all ansible EC2 modules?
see:

if params.get('name') is not None:

The behavior hasn't changed, just the bug. I don't see why it requires documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.