Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User - Fix shadow file parsing on AIX #55230

Merged
merged 1 commit into from Apr 22, 2019

Conversation

Projects
None yet
4 participants
@samdoran
Copy link
Member

commented Apr 12, 2019

SUMMARY

Fixes #54461

The shadow file format for AIX is wildly different than Linux. The code parsing the expiration date string in the shadowfile (only on systems that lack spwd) assumed a Linux-style shadow file, causing an IndexError on AIX.

Implement a separate method for parsing the shadow file and subclass it for AIX in order to do the right thing.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/system/user.py

Fix shadow file parsing on AIX
Implement a method for shadow file parsing.
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

@bcoca

bcoca approved these changes Apr 18, 2019

@samdoran samdoran merged commit f27ecca into ansible:devel Apr 22, 2019

1 check passed

Shippable Run 119470 status is SUCCESS.
Details

@samdoran samdoran deleted the samdoran:issue/54461-aix-user-no-password branch Apr 22, 2019

samdoran added a commit to samdoran/ansible that referenced this pull request Apr 22, 2019

[stable-2.8] User - Fix shadow file parsing on AIX (ansible#55230)
Implement a new method for shadow file parsing so it can be subclassed.
(cherry picked from commit f27ecca)

Co-authored-by: Sam Doran <sdoran@redhat.com>

samdoran added a commit to samdoran/ansible that referenced this pull request Apr 22, 2019

[stable-2.7] User - Fix shadow file parsing on AIX (ansible#55230)
Implement a new method for shadow file parsing so it can be subclassed..
(cherry picked from commit f27ecca)

Co-authored-by: Sam Doran <sdoran@redhat.com>

abadger added a commit that referenced this pull request Apr 24, 2019

[stable-2.8] User - Fix shadow file parsing on AIX (#55230)
Implement a new method for shadow file parsing so it can be subclassed.
(cherry picked from commit f27ecca)

Co-authored-by: Sam Doran <sdoran@redhat.com>

abadger added a commit that referenced this pull request Apr 25, 2019

[stable-2.7] User - Fix shadow file parsing on AIX (#55230)
Implement a new method for shadow file parsing so it can be subclassed..
(cherry picked from commit f27ecca)

Co-authored-by: Sam Doran <sdoran@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.