Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oracle compute instance module #55240

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
4 participants
@nalsaber
Copy link
Contributor

nalsaber commented Apr 13, 2019

SUMMARY

Add oracle compute instance module

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

Oracle cloud infrastructure compute instance module

ADDITIONAL INFORMATION

New files:
lib/ansible/module_utils/oracle/oci_compute_utils.py
lib/ansible/modules/cloud/oracle/oci_instance.py
lib/ansible/modules/cloud/oracle/oci_instance_facts.py
test/units/modules/cloud/oracle/test_oci_instance.py


@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Apr 13, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Apr 13, 2019

@nalsaber this PR contains more than one new module.

Please submit only one new module per pull request. For a detailed explanation, please read the grouped modules documentation

click here for bot help

@@ -21,6 +21,7 @@ netaddr
ipaddress
netapp-lib
solidfire-sdk-python
oci

This comment has been minimized.

Copy link
@mattclay

mattclay Apr 13, 2019

Member

Instead of adding a dependency on oci, can you mock the oci module instead?

See https://github.com/ansible/ansible/pull/50850/files#diff-d075108943a235e1989fb4a5ac471049R38 for an example of how this can be done.

import pytest
import logging

from nose.plugins.skip import SkipTest

This comment has been minimized.

Copy link
@mattclay

mattclay Apr 17, 2019

Member

Use pytest instead of nose.

@jillr jillr removed the needs_triage label Apr 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.