Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Added ability to take snapshots on XenServer #55247
Added a new parameter
Sometimes it's nice to just take a snapshot without turning the VM into a template.
@freaker2k7 Hi. I very much appreciate the effort, but unfortunately, supporting snapshots will not be this easy. Let me ask you right away. Did you test your code before making this pull request?
Here is why. You are calling XenAPI method
To cut story short, snapshot management would be hard to incorporate in xenserver_guest module and for many reasons is best to be implemented in a separate module. Look at
I'll be honest - No I didn't test it :(
But... I didn't invent this method I'm calling - https://developer-docs.citrix.com/projects/xenserver-management-api/en/7.1-ltsr/api-ref-autogen/#rpc-name-setisasnapshot
I'll be able to test it through on Sunday-Monday, currently I'm commiting from my PC.
Just in case, I've tested the method on both
Permission denied error should be accompanied by a message explaining why it was denied. I got an empty string here. This implies that there is some bug in XenAPI implementation itself on at least XenServer 7.2. Citrix XenAPI docs for latest version (7.6) do not have
I believe you have been misled :)