Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading namespaced doc_fragments from collections #55249

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
4 participants
@flowerysong
Copy link
Contributor

commented Apr 13, 2019

SUMMARY

The syntax for specifying a different fragment name was already using '.' as a separator, so the code needed to be tweaked to avoid choking on names like testns.testcoll.fragname and testns.testcoll.fragname.altvar.

get_plugin_class() returns 'docfragment' for the fragment loader; mangling subdir provides consistent alignment with the normal plugin directory names and avoids any need for special handling of plugin types with 'module' in the name.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

PluginLoader

ADDITIONAL INFORMATION

Fix loading namespaced doc_fragments
The syntax for specifying a different fragment name was already
using '.' as a separator, so the code needed to be tweaked to
avoid choking on names like `testns.testcoll.fragname` and
`testns.testcoll.fragname.altvar`.

`get_plugin_class()` returns 'docfragment' for the fragment loader;
mangling `subdir` provides consistent alignment with the normal plugin
directory names and avoids needing special handling of plugin types
with 'module' in the name.

@flowerysong flowerysong force-pushed the flowerysong:coll_doc_fragments branch from ceab4a4 to a54c3f9 Apr 14, 2019

@flowerysong flowerysong changed the title [WIP] Fix loading namespaced doc_fragments Fix loading namespaced doc_fragments Apr 14, 2019

@ansibot ansibot added core_review and removed WIP labels Apr 14, 2019

@flowerysong flowerysong changed the title Fix loading namespaced doc_fragments Fix loading namespaced doc_fragments from collections Apr 14, 2019

@flowerysong

This comment has been minimized.

Copy link
Contributor Author

commented Apr 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.