Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.8] VMware: vmware_tools tls warning fixes #55262

Merged
merged 1 commit into from Apr 16, 2019

Conversation

Projects
None yet
4 participants
@Akasurde
Copy link
Member

commented Apr 14, 2019

SUMMARY
  • vmware_tools: remove silence_tls_warnings option

  • attempt import of bundled urllib3

(cherry picked from commit 7191d45)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

changelogs/fragments/vmware_tools_fix_urllib3_import.yaml
lib/ansible/plugins/connection/vmware_tools.py

[Backport 2.8] VMware: vmware_tools tls warning fixes
* vmware_tools: remove silence_tls_warnings option

* attempt import of bundled urllib3

(cherry picked from commit 7191d45)
@jamescassell
Copy link
Contributor

left a comment

shipit

I'd have guessed no changelog would be required for a plugin that's new in ansible-2.8...

thanks for submitting the backport

@abadger abadger merged commit 8448967 into ansible:stable-2.8 Apr 16, 2019

1 check passed

Shippable Run 119191 status is SUCCESS.
Details
@abadger

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

Merged for the 2.8.0rc1 release.

The reason it needed a changelog is because the 2.8.0 beta1 release included the previous version of this. The changelog will record what changed between beta1 and rc1.

@Akasurde Akasurde deleted the Akasurde:backport/2.8/55187 branch Apr 17, 2019

@Akasurde

This comment has been minimized.

Copy link
Member Author

commented Apr 17, 2019

@jamescassell @abadger Thanks for the reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.