Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.8] Remove unneccessary line in config section of purefa_facts (#55164) #55266

Merged
merged 1 commit into from Apr 23, 2019

Conversation

Projects
None yet
4 participants
@sdodsley
Copy link
Contributor

commented Apr 14, 2019

(cherry picked from commit 30a216b)

SUMMARY

Backport of #55164 to stable-2.8
This line causes a crash of the module in certain circumstances.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

purefa_facts.py

@ansibot

This comment has been minimized.

@sdodsley sdodsley changed the title Remove unneccessary line in config section of purefa_facts (#55164) [Backport 2.8] Remove unneccessary line in config section of purefa_facts (#55164) Apr 14, 2019

@genegr

This comment has been minimized.

Copy link

commented Apr 15, 2019

shipit

@abadger

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

Looks good but this change needs a changelog fragment to be merged. Thanks.

@abadger

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

@sdodsley ping, rc1 is on Thursday, this week. I would like to get this in but it is still missing a changelog fragment.

@sdodsley sdodsley force-pushed the sdodsley:backport/2.8/55164 branch from e6cf7fa to 2a6bca8 Apr 23, 2019

@sdodsley

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

@abadger changelog fragment added.

@abadger abadger merged commit ebd7820 into ansible:stable-2.8 Apr 23, 2019

1 check passed

Shippable Run 120344 status is SUCCESS.
Details
@abadger

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

Merged for the 2.8.0rc1 release.

@sdodsley sdodsley deleted the sdodsley:backport/2.8/55164 branch Apr 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.