Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenBSD bcrypt algorithm #55268

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
4 participants
@evitalis
Copy link

evitalis commented Apr 14, 2019

SUMMARY

Adds a conditional check for OpenBSD to use $2b for the bcrypt algorithm instead of $2a. Its a workaround for the issue linked below until a better fix is possible. This eliminates the need for a custom patch on that platform.

Fixes: #54071

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

encrypt library

ADDITIONAL INFORMATION

Downstream patch located here: https://github.com/openbsd/ports/blob/master/sysutils/ansible/patches/patch-lib_ansible_utils_encrypt_py


@Akasurde
Copy link
Member

Akasurde left a comment

Could you please add integration test for this change in filters?

Show resolved Hide resolved lib/ansible/utils/encrypt.py Outdated

@Akasurde Akasurde self-assigned this Apr 15, 2019

@Akasurde Akasurde removed the needs_triage label Apr 15, 2019

@ansibot ansibot added needs_revision and removed core_review labels Apr 15, 2019

@evitalis

This comment has been minimized.

Copy link
Author

evitalis commented Apr 20, 2019

@Akasurde I took a stab at adding the tests, let me know what you think or if more changes are needed. I also merged in your proposed changes to the encrypt.py file.

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Apr 20, 2019

@evitalis this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@evitalis evitalis force-pushed the evitalis:algo_openbsd branch from 91d4904 to 147b56a Apr 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.